Fix hardcoded strip path when cross-compiling from Linux to Darwin #131480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| r? @nnethercote rustbot has assigned @nnethercote. Use |
rustbot added S-waiting-on-review 
Contributor
| @bors r+ rollup |
Collaborator
bors added S-waiting-on-bors 
rvolosatovs approved these changes Oct 10, 2024
Member
| Does this need a backport? EDIT: no I think it's fine because the beta bump happens later and this should land before that. |
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 10, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#130625 (Fix a few relative paths in rustc doc) - rust-lang#131397 (fix/update teach_note from 'escaping mutable ref/ptr' const-check) - rust-lang#131479 (Apple: Avoid redundant `-Wl,-dylib` flag when linking) - rust-lang#131480 (Fix hardcoded strip path when cross-compiling from Linux to Darwin) - rust-lang#131482 (structurally resolve adts and tuples expectations too) - rust-lang#131484 (Add myself back to review rotation) - rust-lang#131491 (impossible obligations fast path) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 10, 2024
Rollup merge of rust-lang#131480 - madsmtm:macos-fix-strip-binary, r=nnethercote Fix hardcoded strip path when cross-compiling from Linux to Darwin Fixes rust-lang#131206. I fear that rust-lang#131405 might end up taking some time, so opening this PR to resolve the regression. `@rustbot` label O-apple
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #131206.
I fear that #131405 might end up taking some time, so opening this PR to resolve the regression.
@rustbot label O-apple