Skip to content

Remove invalid suggestion of into_iter for extern macro #137415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2025
Merged

Remove invalid suggestion of into_iter for extern macro #137415

merged 1 commit into from
Feb 23, 2025
+56 −5

Conversation

@chenyukang
Copy link
Member

@chenyukang chenyukang commented Feb 22, 2025 •
edited
Loading

Fixes #137345

#109082 is closed due to performance issue, do we have any other solution for this kind of issue?
@rustbot
Copy link
Collaborator

rustbot commented Feb 22, 2025

r? @estebank

rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 22, 2025
@estebank
Copy link
Contributor

estebank commented Feb 22, 2025

#109082 is closed due to performance issue, do we have any other solution for this kind of issue?

I still think that the solution will have to be something like that :-/

@bors r+
@bors
Copy link
Collaborator

bors commented Feb 22, 2025

📌 Commit c45463e has been approved by estebank

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 22, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 22, 2025
@matthiaskrgr
Rollup merge of rust-lang#137415 - chenyukang:yukang-fix-137345-inval…
7937989 
…id-sugg, r=estebank Remove invalid suggestion of into_iter for extern macro Fixes rust-lang#137345 rust-lang#109082 is closed due to performance issue, do we have any other solution for this kind of issue?
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 22, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 22, 2025
@matthiaskrgr
Rollup merge of rust-lang#137415 - chenyukang:yukang-fix-137345-inval…
1d75e4a 
…id-sugg, r=estebank Remove invalid suggestion of into_iter for extern macro Fixes rust-lang#137345 rust-lang#109082 is closed due to performance issue, do we have any other solution for this kind of issue?
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 22, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 22, 2025
@bors
Auto merge of rust-lang#137433 - matthiaskrgr:rollup-9imemce, r=matth…
40a855c 
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#135501 (Inject `compiler_builtins` during postprocessing and ensure it is made private) - rust-lang#136543 (intrinsics: unify rint, roundeven, nearbyint in a single round_ties_even intrinsic) - rust-lang#137121 (stabilize `(const_)ptr_sub_ptr`) - rust-lang#137180 (Give `global_asm` a fake body to store typeck results, represent `sym fn` as a hir expr to fix `sym fn` operands with lifetimes) - rust-lang#137256 (compiler: untangle SIMD alignment assumptions) - rust-lang#137298 (Check signature WF when lowering MIR body) - rust-lang#137415 (Remove invalid suggestion of into_iter for extern macro) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 22, 2025
@matthiaskrgr
Rollup merge of rust-lang#137415 - chenyukang:yukang-fix-137345-inval…
a0d56f0 
…id-sugg, r=estebank Remove invalid suggestion of into_iter for extern macro Fixes rust-lang#137345 rust-lang#109082 is closed due to performance issue, do we have any other solution for this kind of issue?
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 22, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 22, 2025
@bors
Auto merge of rust-lang#137436 - matthiaskrgr:rollup-mqir082, r=matth…
20a8109 
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#135501 (Inject `compiler_builtins` during postprocessing and ensure it is made private) - rust-lang#136543 (intrinsics: unify rint, roundeven, nearbyint in a single round_ties_even intrinsic) - rust-lang#137121 (stabilize `(const_)ptr_sub_ptr`) - rust-lang#137180 (Give `global_asm` a fake body to store typeck results, represent `sym fn` as a hir expr to fix `sym fn` operands with lifetimes) - rust-lang#137256 (compiler: untangle SIMD alignment assumptions) - rust-lang#137383 (stabilize `unsigned_is_multiple_of`) - rust-lang#137415 (Remove invalid suggestion of into_iter for extern macro) r? `@ghost` `@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 22, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 23, 2025
@bors
Auto merge of rust-lang#137446 - matthiaskrgr:rollup-16moy6v, r=matth…
bca5f37 
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#135501 (Inject `compiler_builtins` during postprocessing and ensure it is made private) - rust-lang#137121 (stabilize `(const_)ptr_sub_ptr`) - rust-lang#137180 (Give `global_asm` a fake body to store typeck results, represent `sym fn` as a hir expr to fix `sym fn` operands with lifetimes) - rust-lang#137256 (compiler: untangle SIMD alignment assumptions) - rust-lang#137383 (stabilize `unsigned_is_multiple_of`) - rust-lang#137415 (Remove invalid suggestion of into_iter for extern macro) r? `@ghost` `@rustbot` modify labels: rollup
@bors bors merged commit e780b89 into rust-lang:master Feb 23, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 23, 2025
@rust-timer
Unrolled build for rust-lang#137415
1e94d55 
Rollup merge of rust-lang#137415 - chenyukang:yukang-fix-137345-invalid-sugg, r=estebank Remove invalid suggestion of into_iter for extern macro Fixes rust-lang#137345 rust-lang#109082 is closed due to performance issue, do we have any other solution for this kind of issue?
@rustbot rustbot added this to the 1.87.0 milestone Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

4 participants

@chenyukang @rustbot @estebank @bors