Skip to content

Remove out-of-date noop_* names. #141563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

Remove out-of-date noop_* names. #141563

merged 1 commit into from
May 27, 2025

Conversation

@nnethercote
Copy link
Contributor

@nnethercote nnethercote commented May 25, 2025

mut_visit.rs has a single function with a noop_ prefix: noop_filter_map_expr. This commit renames as walk_filter_map_expr which is consistent with other functions in this file.

The commit also removes out-of-date comments that refer to noop_* methods.

r? @petrochenkov
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 25, 2025
@nnethercote
Copy link
Contributor Author

nnethercote commented May 25, 2025

Pulled out of #141273.
@petrochenkov
Copy link
Contributor

petrochenkov commented May 26, 2025

@bors r+ rollup
@bors
Copy link
Collaborator

bors commented May 26, 2025

📌 Commit 1a29427 has been approved by petrochenkov

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2025
jieyouxu added a commit to jieyouxu/rust that referenced this pull request May 26, 2025
@jieyouxu
Rollup merge of rust-lang#141563 - nnethercote:rm-noop, r=petrochenkov
3d7518f 
Remove out-of-date `noop_*` names. `mut_visit.rs` has a single function with a `noop_` prefix: `noop_filter_map_expr`. This commit renames as `walk_filter_map_expr` which is consistent with other functions in this file. The commit also removes out-of-date comments that refer to `noop_*` methods. r? `@petrochenkov`
@jieyouxu jieyouxu mentioned this pull request May 26, 2025
Closed
@bors
Copy link
Collaborator

bors commented May 27, 2025

☔ The latest upstream changes (presumably #141605) made this pull request unmergeable. Please resolve the merge conflicts.
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 27, 2025
@nnethercote
Remove out-of-date noop_* names.
89c21f7 
`mut_visit.rs` has a single function with a `noop_` prefix: `noop_filter_map_expr`. This commit renames as `walk_filter_map_expr` which is consistent with other functions in this file. The commit also removes out-of-date comments that refer to `noop_*` methods.
@nnethercote
Copy link
Contributor Author

nnethercote commented May 27, 2025

@bors r=petrochenkov
@bors
Copy link
Collaborator

bors commented May 27, 2025

📌 Commit 89c21f7 has been approved by petrochenkov

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 27, 2025
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented May 27, 2025

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
#2 transferring dockerfile: 2.62kB done #2 DONE 0.0s #3 [internal] load metadata for docker.io/library/ubuntu:22.04 #3 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/ubuntu/manifests/sha256:67cadaff1dca187079fce41360d5a7eb6f7dcd3745e53c79ad5efd8563118240: 429 Too Many Requests - Server message: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit ------ > [internal] load metadata for docker.io/library/ubuntu:22.04: ------ Dockerfile:1 -------------------- 1 | >>> FROM ubuntu:22.04 2 | 3 | ARG DEBIAN_FRONTEND=noninteractive -------------------- ERROR: failed to solve: ubuntu:22.04: failed to resolve source metadata for docker.io/library/ubuntu:22.04: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/ubuntu/manifests/sha256:67cadaff1dca187079fce41360d5a7eb6f7dcd3745e53c79ad5efd8563118240: 429 Too Many Requests - Server message: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit Command failed. Attempt 2/5: #0 building with "vigilant_blackburn" instance using docker-container driver #1 [internal] load build definition from Dockerfile #1 transferring dockerfile: 2.62kB done #1 DONE 0.0s #2 [internal] load metadata for docker.io/library/ubuntu:22.04 #2 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/ubuntu/manifests/sha256:67cadaff1dca187079fce41360d5a7eb6f7dcd3745e53c79ad5efd8563118240: 429 Too Many Requests - Server message: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit ------ > [internal] load metadata for docker.io/library/ubuntu:22.04: ------ Dockerfile:1 -------------------- 1 | >>> FROM ubuntu:22.04 2 | 3 | ARG DEBIAN_FRONTEND=noninteractive -------------------- ERROR: failed to solve: ubuntu:22.04: failed to resolve source metadata for docker.io/library/ubuntu:22.04: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/ubuntu/manifests/sha256:67cadaff1dca187079fce41360d5a7eb6f7dcd3745e53c79ad5efd8563118240: 429 Too Many Requests - Server message: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit Command failed. Attempt 3/5: #0 building with "vigilant_blackburn" instance using docker-container driver #1 [internal] load build definition from Dockerfile #1 transferring dockerfile: 2.62kB done #1 DONE 0.0s #2 [internal] load metadata for docker.io/library/ubuntu:22.04 #2 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/ubuntu/manifests/sha256:67cadaff1dca187079fce41360d5a7eb6f7dcd3745e53c79ad5efd8563118240: 429 Too Many Requests - Server message: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit ------ > [internal] load metadata for docker.io/library/ubuntu:22.04: ------ Dockerfile:1 -------------------- 1 | >>> FROM ubuntu:22.04 2 | 3 | ARG DEBIAN_FRONTEND=noninteractive -------------------- ERROR: failed to solve: ubuntu:22.04: failed to resolve source metadata for docker.io/library/ubuntu:22.04: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/ubuntu/manifests/sha256:67cadaff1dca187079fce41360d5a7eb6f7dcd3745e53c79ad5efd8563118240: 429 Too Many Requests - Server message: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit Command failed. Attempt 4/5: #0 building with "vigilant_blackburn" instance using docker-container driver #1 [internal] load build definition from Dockerfile #1 transferring dockerfile: 2.62kB done #1 DONE 0.0s #2 [internal] load metadata for docker.io/library/ubuntu:22.04 #2 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/ubuntu/manifests/sha256:67cadaff1dca187079fce41360d5a7eb6f7dcd3745e53c79ad5efd8563118240: 429 Too Many Requests - Server message: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit ------ > [internal] load metadata for docker.io/library/ubuntu:22.04: ------ Dockerfile:1 -------------------- 1 | >>> FROM ubuntu:22.04 2 | 3 | ARG DEBIAN_FRONTEND=noninteractive -------------------- ERROR: failed to solve: ubuntu:22.04: failed to resolve source metadata for docker.io/library/ubuntu:22.04: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/ubuntu/manifests/sha256:67cadaff1dca187079fce41360d5a7eb6f7dcd3745e53c79ad5efd8563118240: 429 Too Many Requests - Server message: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit Command failed. Attempt 5/5: #0 building with "vigilant_blackburn" instance using docker-container driver #1 [internal] load build definition from Dockerfile #1 transferring dockerfile: 2.62kB done #1 DONE 0.0s #2 [internal] load metadata for docker.io/library/ubuntu:22.04 #2 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/ubuntu/manifests/sha256:67cadaff1dca187079fce41360d5a7eb6f7dcd3745e53c79ad5efd8563118240: 429 Too Many Requests - Server message: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit ------ > [internal] load metadata for docker.io/library/ubuntu:22.04: ------ Dockerfile:1 -------------------- 1 | >>> FROM ubuntu:22.04 2 | 3 | ARG DEBIAN_FRONTEND=noninteractive -------------------- ERROR: failed to solve: ubuntu:22.04: failed to resolve source metadata for docker.io/library/ubuntu:22.04: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/ubuntu/manifests/sha256:67cadaff1dca187079fce41360d5a7eb6f7dcd3745e53c79ad5efd8563118240: 429 Too Many Requests - Server message: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit The command has failed after 5 attempts. ##[error]Process completed with exit code 1. Post job cleanup.
@compiler-errors compiler-errors mentioned this pull request May 27, 2025
Merged
bors added a commit that referenced this pull request May 27, 2025
@bors
Auto merge of #141644 - compiler-errors:rollup-gl5hize, r=compiler-er…
c583fa6 
…rors Rollup of 17 pull requests Successful merges: - #140591 (Fix malformed suggestion for E0061 when method is a macro token in macro context) - #141536 (Improve `ambiguous_wide_pointer_comparisons` lint compare diagnostics) - #141552 (Pull out dedicated `cfg_version` syntax test from feature gate test) - #141556 (bootstrap: translate Windows paths in a way that works for both Cygwin and MSYS2) - #141563 (Remove out-of-date `noop_*` names.) - #141568 (dist: make sure llvm-project submodule is present) - #141580 (Use more detailed spans in dyn compat errors within bodies) - #141582 (intrinsics, ScalarInt: minor cleanup) - #141584 (Support `opaque_types_defined_by` for `SyntheticCoroutineBody`) - #141587 (Add missing edition directives for async-await tests) - #141594 (Add `generic_arg_infer` test) - #141596 (rustc book: fix erratic sentence by making it more simple) - #141599 (Remove an unnecessary use of `Box::into_inner`.) - #141611 (Update mdbook to 0.4.51) - #141616 (Remove spastorino from vacations) - #141623 (use custom types to clarify arguments to `emit_ptr_va_arg`) - #141635 (further dedup `WalkItemKind` for `mut_visit` and `visit`) r? `@ghost` `@rustbot` modify labels: rollup
@bors bors merged commit 7acdffb into rust-lang:master May 27, 2025
3 of 7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 27, 2025
rust-timer added a commit that referenced this pull request May 27, 2025
@rust-timer
Unrolled build for #141563
269a1e8 
Rollup merge of #141563 - nnethercote:rm-noop, r=petrochenkov Remove out-of-date `noop_*` names. `mut_visit.rs` has a single function with a `noop_` prefix: `noop_filter_map_expr`. This commit renames as `walk_filter_map_expr` which is consistent with other functions in this file. The commit also removes out-of-date comments that refer to `noop_*` methods. r? `@petrochenkov`
@nnethercote nnethercote deleted the rm-noop branch May 27, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

5 participants

@nnethercote @petrochenkov @bors @rust-log-analyzer @rustbot