Do not enable split debuginfo for windows-gnu#152870
Do not enable split debuginfo for windows-gnu#152870rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
Because rustc doesn't handle split debuginfo for these targets, enabling that option causes them to be missing some of the debuginfo.
| rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
| To avoid ballooning commit message, I'm posting the backtraces of i686-pc-windows-gnu, x86_64-pc-windows-gnu and x86_64-pc-windows-gnullvm targets here. Before this PR: Details
With this PR: Details
Tested code: Details
❯ bat src/main.rs -p fn main() { println!( "{:?}", std::panic::catch_unwind(|| { panic!("Hello, world!"); }) ); }I first noticed the problem when trying to debug a different issue, and I ran GNU objdump: Details
|
| Just in case, let's see if the CI likes it: @bors try jobs=dist-aarch64-llvm-mingw,dist-i686-mingw,dist-x86_64-llvm-mingw,dist-x86_64-mingw,x86_64-mingw-1,x86_64-mingw-2 |
This comment has been minimized.
This comment has been minimized.
…tstrap, r=<try> Do not enable split debuginfo for windows-gnu try-job: dist-aarch64-llvm-mingw try-job: dist-i686-mingw try-job: dist-x86_64-llvm-mingw try-job: dist-x86_64-mingw try-job: x86_64-mingw-1 try-job: x86_64-mingw-2
| 💔 Test for ac89ce2 failed: CI. Failed job:
|
@bors try jobs=dist-i686-mingw,dist-x86_64-llvm-mingw,dist-x86_64-mingw,x86_64-mingw-1,x86_64-mingw-2 |
This comment has been minimized.
This comment has been minimized.
…tstrap, r=<try> Do not enable split debuginfo for windows-gnu try-job: dist-i686-mingw try-job: dist-x86_64-llvm-mingw try-job: dist-x86_64-mingw try-job: x86_64-mingw-1 try-job: x86_64-mingw-2
| Oh, I didn't realize it was marked as waiting on me by bors. @rustbot ready |
| #split-debuginfo = if linux { off } else if windows { packed } else if apple { unpacked } | ||
| # On Windows MSVC platforms, packed debuginfo is the only supported option, | ||
| # producing a `.pdb` file. On Windows GNU rustc doesn't support splitting debuginfo, | ||
| # and enabling it causes issues. |
There was a problem hiding this comment.
Should we be warning about it from rustc and/or erroring out?
There was a problem hiding this comment.
Honestly? I don't know.
I haven't tried that but it should be possible to make split debuginfo work with the right combination of linker flags. For example when linking with LLD one can add argument to create .pdb files with debuginfo. I don't know whether this needs compiler support.
I'm totally clueless whether split debuginfo is possible with Dwarf on Windows.
…info-in-bootstrap, r=Mark-Simulacrum Do not enable split debuginfo for windows-gnu Because rustc doesn't handle split debuginfo for these targets, enabling that option causes them to be missing some of the debuginfo.
…info-in-bootstrap, r=Mark-Simulacrum Do not enable split debuginfo for windows-gnu Because rustc doesn't handle split debuginfo for these targets, enabling that option causes them to be missing some of the debuginfo.
…info-in-bootstrap, r=Mark-Simulacrum Do not enable split debuginfo for windows-gnu Because rustc doesn't handle split debuginfo for these targets, enabling that option causes them to be missing some of the debuginfo.
…uwer Rollup of 12 pull requests Successful merges: - #152870 (Do not enable split debuginfo for windows-gnu) - #153333 (Fix bootstrap rust build failure for vxworks) - #153681 (ci: add runners for vanilla LLVM 22) - #153824 (Add `Wake` diagnostic item for `alloc::task::Wake`) - #154077 (Optimize 128-bit integer formatting) - #154078 (`define_callbacks` tweaks) - #151905 (Split the `dec2flt::RawFloat` trait for easier reuse) - #153170 (Add is_disconnected functions to mpsc and mpmc channels) - #153804 (Derive Macro Eq: link to more detailed documentation) - #153974 (Point at return type when it is the source of the type expectation) - #154018 (simplify and remove `tests/ui/kindck` and related tests) - #154041 (bootstrap: Allow `--bless`ing changes to editor settings files)
…info-in-bootstrap, r=Mark-Simulacrum Do not enable split debuginfo for windows-gnu Because rustc doesn't handle split debuginfo for these targets, enabling that option causes them to be missing some of the debuginfo.
…info-in-bootstrap, r=Mark-Simulacrum Do not enable split debuginfo for windows-gnu Because rustc doesn't handle split debuginfo for these targets, enabling that option causes them to be missing some of the debuginfo.
…uwer Rollup of 19 pull requests Successful merges: - #152870 (Do not enable split debuginfo for windows-gnu) - #153333 (Fix bootstrap rust build failure for vxworks) - #153681 (ci: add runners for vanilla LLVM 22) - #153727 (When single impl can satisfy inference error, suggest type) - #153824 (Add `Wake` diagnostic item for `alloc::task::Wake`) - #154077 (Optimize 128-bit integer formatting) - #154078 (`define_callbacks` tweaks) - #151905 (Split the `dec2flt::RawFloat` trait for easier reuse) - #153170 (Add is_disconnected functions to mpsc and mpmc channels) - #153308 (Add hygiene annotations for tokens in `macro_rules!` bodies) - #153557 (fix inference variables leaking into HIR const literal lowering logic) - #153804 (Derive Macro Eq: link to more detailed documentation) - #153913 (Fix some suggestions of the `for-loops-over-fallibles` lint) - #153974 (Point at return type when it is the source of the type expectation) - #153987 (mGCA: Lower const generic args to infer when needed) - #154018 (simplify and remove `tests/ui/kindck` and related tests) - #154036 (borrowck/type_check: remove helper left-over from unsized locals) - #154038 (merge `regions-outlives-nominal-type-*` tests into one file) - #154041 (bootstrap: Allow `--bless`ing changes to editor settings files)
…uwer Rollup of 19 pull requests Successful merges: - #152870 (Do not enable split debuginfo for windows-gnu) - #153333 (Fix bootstrap rust build failure for vxworks) - #153681 (ci: add runners for vanilla LLVM 22) - #153727 (When single impl can satisfy inference error, suggest type) - #153824 (Add `Wake` diagnostic item for `alloc::task::Wake`) - #154077 (Optimize 128-bit integer formatting) - #154078 (`define_callbacks` tweaks) - #151905 (Split the `dec2flt::RawFloat` trait for easier reuse) - #153170 (Add is_disconnected functions to mpsc and mpmc channels) - #153308 (Add hygiene annotations for tokens in `macro_rules!` bodies) - #153557 (fix inference variables leaking into HIR const literal lowering logic) - #153804 (Derive Macro Eq: link to more detailed documentation) - #153913 (Fix some suggestions of the `for-loops-over-fallibles` lint) - #153974 (Point at return type when it is the source of the type expectation) - #153987 (mGCA: Lower const generic args to infer when needed) - #154018 (simplify and remove `tests/ui/kindck` and related tests) - #154036 (borrowck/type_check: remove helper left-over from unsized locals) - #154038 (merge `regions-outlives-nominal-type-*` tests into one file) - #154041 (bootstrap: Allow `--bless`ing changes to editor settings files)
Because rustc doesn't handle split debuginfo for these targets, enabling that option causes them to be missing some of the debuginfo.