Skip to content

Ship profiler with windows-gnu #61080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2019
Merged

Ship profiler with windows-gnu #61080

merged 1 commit into from
May 26, 2019
+7 −3

Conversation

@mati865
Copy link
Member

@mati865 mati865 commented May 23, 2019 •
edited
Loading

Fixes #49409

I don't know if we can enable it for testing, windows-gnu jobs are already taking too long: #59637.

r? @michaelwoerister

P.S.
I have tested only x86_64 build.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 23, 2019
@sanxiyn
Copy link
Contributor

sanxiyn commented May 24, 2019

@bors r+
@bors
Copy link
Collaborator

bors commented May 24, 2019

📌 Commit 1a35a1c has been approved by sanxiyn
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 24, 2019
Centril added a commit to Centril/rust that referenced this pull request May 25, 2019
@Centril
Rollup merge of rust-lang#61080 - mati865:mingw_pgo, r=sanxiyn
c907f03 
Ship profiler with windows-gnu Fixes rust-lang#49409 I don't know if we can enable it for testing, windows-gnu jobs are already taking too long: rust-lang#59637. r? @michaelwoerister P.S. I have tested only x86_64 build.
@Centril Centril mentioned this pull request May 25, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request May 25, 2019
@Centril
Rollup merge of rust-lang#61153 - Centril:rollup-b9qpiez, r=Centril
400d0df 
Rollup of 5 pull requests Successful merges: - rust-lang#60928 (Changes the type `mir::Mir` into `mir::Body`) - rust-lang#61035 (Avoid more symbol interning) - rust-lang#61036 (PGO - Add a smoketest for combining PGO with cross-language LTO.) - rust-lang#61077 (Don't arena-allocate static symbols.) - rust-lang#61080 (Ship profiler with windows-gnu) Failed merges: r? @ghost
Centril added a commit to Centril/rust that referenced this pull request May 25, 2019
@Centril
Rollup merge of rust-lang#61080 - mati865:mingw_pgo, r=sanxiyn
e6eaff6 
Ship profiler with windows-gnu Fixes rust-lang#49409 I don't know if we can enable it for testing, windows-gnu jobs are already taking too long: rust-lang#59637. r? @michaelwoerister P.S. I have tested only x86_64 build.
@Centril Centril mentioned this pull request May 25, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request May 25, 2019
@Centril
Rollup merge of rust-lang#61080 - mati865:mingw_pgo, r=sanxiyn
1625abf 
Ship profiler with windows-gnu Fixes rust-lang#49409 I don't know if we can enable it for testing, windows-gnu jobs are already taking too long: rust-lang#59637. r? @michaelwoerister P.S. I have tested only x86_64 build.
@Centril Centril mentioned this pull request May 25, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request May 25, 2019
@Centril
Rollup merge of rust-lang#61080 - mati865:mingw_pgo, r=sanxiyn
3674ed8 
Ship profiler with windows-gnu Fixes rust-lang#49409 I don't know if we can enable it for testing, windows-gnu jobs are already taking too long: rust-lang#59637. r? @michaelwoerister P.S. I have tested only x86_64 build.
@Centril Centril mentioned this pull request May 25, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request May 25, 2019
@Centril
Rollup merge of rust-lang#61080 - mati865:mingw_pgo, r=sanxiyn
94b29f3 
Ship profiler with windows-gnu Fixes rust-lang#49409 I don't know if we can enable it for testing, windows-gnu jobs are already taking too long: rust-lang#59637. r? @michaelwoerister P.S. I have tested only x86_64 build.
@Centril Centril mentioned this pull request May 25, 2019
Closed
@bors
Copy link
Collaborator

bors commented May 26, 2019

⌛ Testing commit 1a35a1c with merge 566f3d7...
bors added a commit that referenced this pull request May 26, 2019
@bors
Auto merge of #61080 - mati865:mingw_pgo, r=sanxiyn
566f3d7 
Ship profiler with windows-gnu Fixes #49409 I don't know if we can enable it for testing, windows-gnu jobs are already taking too long: #59637. r? @michaelwoerister P.S. I have tested only x86_64 build.
@bors
Copy link
Collaborator

bors commented May 26, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: sanxiyn
Pushing 566f3d7 to master...
@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 26, 2019
@bors bors merged commit 1a35a1c into rust-lang:master May 26, 2019
@mati865 mati865 deleted the mingw_pgo branch May 26, 2019 15:26
@leonardo-m
Copy link

leonardo-m commented May 27, 2019

Now on the latest Nightly:

rustc 1.36.0-nightly (5187be620 2019-05-26) commit-hash: 5187be620c76a313a19b9b596e1bce3a80a345dd commit-date: 2019-05-26 host: x86_64-pc-windows-gnu

This command works and generates a binary:

rustc -Z pgo-gen=abc test.rs

But the binary crashes immediately.
@mati865
Copy link
Member Author

mati865 commented May 27, 2019

Interesting, can you give share the code and backtrace?
I tested few examples including one that causes ploblems with msvc and everything was fine.
@michaelwoerister michaelwoerister mentioned this pull request May 28, 2019
Merged
@mati865 mati865 mentioned this pull request May 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

6 participants

@mati865 @sanxiyn @bors @leonardo-m @michaelwoerister @rust-highfive