Rollup of 8 pull requests #82249
Merged
Rollup of 8 pull requests #82249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The `rustc_data_structures::sync::OnceCell` is thread-safe when building a parallel compiler. This is unnecessary for the purposes of pattern usefulness checking. Use `!Sync` `std::lazy::OnceCell` instead.
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Example code: ``` fn opts() -> Option<String> { let s: Option<String> = Some(String::new()); Some(s?) // this can just be "s" } ``` 
Add diagnostics for specific cases for const/type mismatch err For now, this adds at least more information so better diagnostics can be emitted for const mismatch errors. I'm not sure what exactly we want to emit, so I've left notes there temporarily, also to see if this is the right approach r? ```@lcnr``` cc: ```@estebank```
Use !Sync std::lazy::OnceCell in usefulness checking The `rustc_data_structures::sync::OnceCell` is thread-safe when building a parallel compiler. This is unnecessary for the purposes of pattern usefulness checking. Use `!Sync` `std::lazy::OnceCell` instead.
add specs for riscv32/riscv64 musl targets Signed-off-by: Khem Raj <raj.khem@gmail.com>
…-DPC Move some tests to more reasonable directories - 4 cc rust-lang#81941
…ter, r=jyn514 make `suggest_setup` help messages better When I first built the compiler and didn't create a `config.toml.example`, the following was emitted: ``` help: consider running `x.py setup` or copying `config.toml.example` ``` I ran `x.py setup` but got an error so in this PR I made the help messages a little clearer.
Remove redundant rustc_data_structures path component
remove useless ?s (clippy::needless_question_marks) Example code: ```rust fn opts() -> Option<String> { let s: Option<String> = Some(String::new()); Some(s?) // this can just be "s" } ``` Add more intra-doc links to std::io
Member Author
| @bors r+ p=8 rollup=never |
Collaborator
| 📌 Commit 21283da has been approved by |
bors added the S-waiting-on-bors Collaborator
Collaborator
| ☀️ Test successful - checks-actions |
Collaborator
| A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
This was referenced Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Successful merges:
suggest_setuphelp messages better #82211 (makesuggest_setuphelp messages better)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup