Fix annotations being not expected in the middle of an array type by java parser

[fan-tom]

Closes #19642

Currently Java parser doesn't expect annotation between type name and square brackets in an array type, or between pairs of square brackets in nested array types.

I added a call to corresponding parser method annotations when parsing array types.

I also changed an unnecessary var to val, as IDEA suggested.

[hamzaremmal]

Hi @fan-tom. thanks for contributing to Scala 3 🎉 . Your changes only covers half of the issue (type annotations on array). To fully close the linked issue, a fix for path selection has to be submitted. Would you like to try fixing it or should we take it from here ? Your changes for annotations on array types are correct and can be merged when all the requirements to close the issue are met.

[fan-tom]

Thanks @hamzaremmal

Would you like to try fixing it

Definitely, but I need inputs for that, like what's path selection. If possible, I'd like to get help writing a test case, from which I can unwind what and where exactly in code goes wrong. I tried to search for this term in https://dotty.epfl.ch/docs but got nothing

[fan-tom]

Oh, I just got that original issue speaks about such syntax Class.@TpeAnnot NestedClass

[fan-tom]

@hamzaremmal hasn't path selection syntax been fixed in #21867? At least the MRE test from the original issue passes, without any additional fixes from my side. Seems issue and PR were not linked properly.

[hamzaremmal]

@hamzaremmal hasn't path selection syntax been fixed in #21867? At least the MRE test from the original issue passes, without any additional fixes from my side. Seems issue and PR were not linked properly.

Ah yes, it does