Functions to QC histopathology images #1036
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
3 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@ ## main #1036 +/- ## ========================================== - Coverage 24.05% 23.31% -0.75% ========================================== Files 43 46 +3 Lines 6380 6931 +551 Branches 1063 1152 +89 ========================================== + Hits 1535 1616 +81 - Misses 4828 5298 +470 Partials 17 17
🚀 New features to boost your workflow:
|
| from ._utils import _flatten_channels, _get_element_data | ||
| | ||
| | ||
| class DETECT_TISSUE_METHOD(enum.Enum): |
Member
There was a problem hiding this comment.
I just noticed this Enum. I think the Enum classes themselves are supposed to be in UpperCamelCase.
https://docs.python.org/3/howto/enum.html
Because Enums are used to represent constants, and to help avoid issues with name clashes between mixin-class methods/attributes and enum names, we strongly recommend using UPPER_CASE names for members, and will be using that style in our examples.
| from ._utils import _flatten_channels, _get_element_data | ||
| | ||
| | ||
| class DETECT_TISSUE_METHOD(enum.Enum): |
Member
There was a problem hiding this comment.
Suggested change
| class DETECT_TISSUE_METHOD(enum.Enum): | |
| class DetectTissueMethod(enum.Enum): |
selmanozleyen approved these changes Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please search among the Pull requests before creating one.
Description
How has this been tested?
Closes