net: Support no_proxy and https_proxy#41689
Merged
TimvdLippe merged 3 commits intoservo:mainfrom Jan 6, 2026
Merged
Conversation
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
jschwe reviewed Jan 5, 2026
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
jschwe reviewed Jan 5, 2026
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
jschwe approved these changes Jan 6, 2026
Member
| Seems to be a issue with Apache server, which contains Kotlin resource to build Android. I just tried and the resource can be fetched now. Let's run that test. |
| 🔨 Triggering try run (#20749145398) for Android |
| |
Member
I don't know why runner cannot get these. |
Contributor Author
| There is some problem on github currently. There is already a discussion on zulip: #general > Android builds are busted atm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This now respects the no_proxy and https_proxy variables with a matching pref (read from the environment).
We now have a new ProxyConnector which uses the hyper_util match to either construct a Tunnel or clone the ServoHttpConnector inside.
This could potentially be slower if every connection is proxied as we redo the tunnel for every new connection. I think this is how the structure is intended to be used as
technically the http_proxy variable can have different proxy assignments per uri.
Signed-off-by: Narfinger Narfinger@users.noreply.github.com
Testing: Tested via setting the no_proxy variable and testing those websites vs proxied websites.
Fixes: #41687