Skip to content

script: Use document origin instead of URL when manipulating blobs.#41966

Merged
jdm merged 4 commits intoservo:mainfrom
jdm:blob-origin
Jan 17, 2026
Merged

script: Use document origin instead of URL when manipulating blobs.#41966
jdm merged 4 commits intoservo:mainfrom
jdm:blob-origin

Conversation

@jdm
Copy link
Member

@jdm jdm commented Jan 16, 2026

Retrieving the origin from the document's URL means the wrong origin can be returned for documents like about:blank or about:srcdoc.

Testing: Newly-passing test involving a srcdoc and blob.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
@jdm jdm requested a review from gterzian as a code owner January 16, 2026 19:56
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 16, 2026
@jdm
Copy link
Member Author

jdm commented Jan 16, 2026

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jan 16, 2026
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 17, 2026
@jdm jdm enabled auto-merge January 17, 2026 04:50
jdm added 2 commits January 17, 2026 02:23
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
@jdm jdm added this pull request to the merge queue Jan 17, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 17, 2026
Merged via the queue into servo:main with commit 6e948ee Jan 17, 2026
29 checks passed
@jdm jdm deleted the blob-origin branch January 17, 2026 08:13
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

3 participants