layout: Properly propagate baselines of flex items that do not participate in baseline alignment by lukewarlow · Pull Request #42038 · servo/servo

lukewarlow · 2026-01-20T23:48:38Z

Fix baseline propagation from flex containers

Flex item layout previously conflated baselines that got propagated and baseline alignment within flex.

Testing: Before and after layout of the manual test cases.

test.html (from original issue)

test2.html (from Oriol's comment)

Fixes: #41905

lukewarlow · 2026-01-20T23:48:45Z

This does introduce a few new test failures but from what I can work out these are actual bugs that were previously hidden by the existing behaviour?

github-actions · 2026-01-21T07:11:46Z

🔨 Triggering try run (#21200578750) for Linux (WPT)

github-actions · 2026-01-21T08:08:06Z

Test results for linux-wpt from try job (#21200578750):

Flaky unexpected result (28)

OK /IndexedDB/get-databases.any.html

FAIL [expected PASS] subtest: Enumerate one database.

promise_test: Unhandled rejection with value: object "Error: indexedDB.open should not succeed without creating a versionchange transaction"

FAIL [expected PASS] subtest: Make sure an empty list is returned for the case of no databases.

promise_test: Unhandled rejection with value: object "Error: indexedDB.open should not succeed without creating a versionchange transaction"

OK /IndexedDB/idbfactory-open-error-properties.any.html
- PASS [expected FAIL] subtest: Properties of error event from failed open()
OK /IndexedDB/idbfactory-open-error-properties.any.worker.html
- PASS [expected FAIL] subtest: Properties of error event from failed open()
PASS [expected FAIL] /_mozilla/css/linear_gradients_reverse_a.html
OK /_mozilla/webxr/create_session.https.html
- FAIL [expected PASS] subtest: create_session
```
can't access property "simulateDeviceConnection", navigator.xr.test is undefined 
```
ERROR [expected TIMEOUT] /_mozilla/webxr/sessionavailable.https.html
CRASH [expected FAIL] /css/css-display/display-contents-dynamic-flex-002-none.html (#42045)
OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: Single value - empty name exists
- PASS [expected FAIL] subtest: Newline normalization - \r\n in name (urlencoded)
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/multiple-iframes.https.window.html (#35176)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Same site
OK [expected ERROR] /focus/focus-event-after-switching-iframes.sub.html (#40368)
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- PASS [expected FAIL] subtest: load event does not fire on window.open('about:blank')
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
OK /html/browsers/windows/browsing-context-names/duplicate-name-order.html (#34623)
- PASS [expected FAIL] subtest: Duplicate name lookup order
OK /html/browsers/windows/embedded-opener-remove-frame.html (#23867)
- PASS [expected FAIL] subtest: opener of discarded auxiliary browsing context
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- FAIL [expected TIMEOUT] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks
```
assert_array_equals: animationFrame lengths differ, expected array ["autofocus", "scroll", "animationFrame"] length 3, got ["animationFrame"] length 1 
```
TIMEOUT /html/semantics/embedded-content/media-elements/autoplay-disabled-by-feature-policy.https.sub.html (#41221)
- FAIL [expected TIMEOUT] subtest: Feature-Policy header: autoplay "none" disallows same-origin iframes.
```
assert_false: autoplay expected false got true 
```
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- FAIL [expected PASS] subtest: multipart/form-data: Basic test (formdata event)
```
assert_equals: expected "\r\nContent-Disposition: form-data; name=\"basic\"\r\n\r\ntest\r\n--\r\n" but got "" 
```
- PASS [expected FAIL] subtest: multipart/form-data: 0x00 in value (formdata event)
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: \r\n in name (normal form)
- PASS [expected FAIL] subtest: text/plain: single quote in filename (normal form)
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: Basic File test (formdata event)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: 0x00 in value (formdata event)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: single quote in name (normal form)
ERROR [expected TIMEOUT] /html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base.html (#40347)
OK /service-workers/service-worker/fetch-event.https.html (#36234)
- PASS [expected FAIL] subtest: Service Worker falls back to network in fetch event with POST form
OK /touch-events/single-tap-when-touchend-listener-use-sync-xhr.html (#41175)
- PASS [expected FAIL] subtest: Click event should be fired when touchend opens synchronous XHR
CRASH [expected OK] /trusted-types/Element-toggleAttribute.html
CRASH [expected OK] /trusted-types/Node-multiple-arguments.html
CRASH [expected ERROR] /trusted-types/block-string-assignment-to-SharedWorker-setTimeout-setInterval.html
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- PASS [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\"" 
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\"" 
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy making the URL invalid in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\"" 
```
TIMEOUT [expected OK] /webdriver/tests/classic/perform_actions/user_prompts.py

Stable unexpected results that are known to be intermittent (33)

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() { cursor.continuePrimaryKey(2, 2); }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.worker.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() { cursor.continuePrimaryKey(2, 2); }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbrequest-onupgradeneeded.any.html (#38895)
- PASS [expected FAIL] subtest: transaction oncomplete ordering relative to open request onsuccess
OK /IndexedDB/idbrequest-onupgradeneeded.any.worker.html (#38971)
- PASS [expected FAIL] subtest: transaction oncomplete ordering relative to open request onsuccess

OK /IndexedDB/key-conversion-exceptions.any.html (#39305)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; { receiver[method](key); }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] subtest: IDBCursor update() method with throwing/invalid keys

assert_throws_exactly: throwing getter should rethrow during clone function "() =&gt; { cursor.update(value); }" threw object "TypeError: cursor.update is not a function" but we expected it to throw object "getter: throwing from getter"

OK /IndexedDB/key-conversion-exceptions.any.worker.html (#39284)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; { receiver[method](key); }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] subtest: IDBCursor update() method with throwing/invalid keys

assert_throws_exactly: throwing getter should rethrow during clone function "() =&gt; { cursor.update(value); }" threw object "TypeError: cursor.update is not a function" but we expected it to throw object "getter: throwing from getter"

OK /IndexedDB/transaction-deactivation-timing.any.html (#38772)
- PASS [expected FAIL] subtest: New transactions are deactivated before next task
- PASS [expected FAIL] subtest: New transactions from microtask are deactivated before next task
FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out 
```

OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)

PASS [expected FAIL] subtest: WebGL test #85
PASS [expected FAIL] subtest: WebGL test #87
PASS [expected FAIL] subtest: WebGL test #89
PASS [expected FAIL] subtest: WebGL test #91

FAIL [expected PASS] subtest: WebGL test #93

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #95

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

FAIL [expected PASS] subtest: WebGL test #97

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #99

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

TIMEOUT /content-security-policy/inheritance/location-reload.html (#38983)
- PASS [expected FAIL] subtest: location.reload() of empty iframe.
OK /css/css-cascade/layer-cssom-order-reverse.html (#36094)
- PASS [expected FAIL] subtest: Delete layer invalidates @font-face
OK /css/css-cascade/layer-font-face-override.html (#35935)
- FAIL [expected PASS] subtest: @font-face override update with appended sheet 1
```
assert_equals: expected "80px" but got "41.45px" 
```
OK /css/css-fonts/generic-family-keywords-001.html (#37467)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(nastaliq)
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted cursive (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted fantasy (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted system-ui (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted math (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(nastaliq) (drawing text in a canvas)
TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
- TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up
```
Test timed out 
```
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/accumulated-oversized-payload.https.window.html (#41705)
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3]) 
```
ERROR [expected TIMEOUT] /html/browsers/history/the-location-interface/location_replace_session_history.html (#41896)
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-empty.html (#28259)
- TIMEOUT [expected FAIL] subtest: Autofocus elements in top-level browsing context's documents with empty fragments should work.
```
Test timed out 
```

OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus

assert_equals: expected Element node &lt;div autofocus=""&gt;&lt;/div&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped

assert_equals: expected Element node &lt;input autofocus=""&gt;&lt;/input&gt; but got Element node &lt;body&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Area element should support autofocus

assert_equals: expected Element node &lt;area autofocus="" href="/common/blank.html"&gt;&lt;/area&gt; but got Element node &lt;body&gt; &lt;img src="/media/poster.png" usemap="#map"&gt; &lt;map n...

TIMEOUT /html/semantics/embedded-content/media-elements/autoplay-allowed-by-feature-policy.https.sub.html (#41404)
- PASS [expected TIMEOUT] subtest: Feature-Policy header: autoplay * allows same-origin iframes.
TIMEOUT /html/semantics/embedded-content/media-elements/autoplay-default-feature-policy.https.sub.html (#41193)
- PASS [expected TIMEOUT] subtest: Default "autoplay" feature policy ["self"] allows same-origin iframes.
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
FAIL [expected PASS] /png/apng/acTL-plays-one.html (#41218)
OK /preload/prefetch-document.html (#37210)
- PASS [expected FAIL] subtest: different-site document prefetch with 'as=document' should not be consumed
TIMEOUT /resource-timing/test_resource_timing.html (#25720)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
```
assert_equals: expected 20.429999999999996 but got 20.43 
```
TIMEOUT /resource-timing/test_resource_timing.https.html (#25216)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (xmlhttprequest)
PASS [expected TIMEOUT] /visual-viewport/viewport-apply-initial-scale-after-navigation.html (#41582)
OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
ERROR [expected OK] /webxr/render_state_update.https.html (#27535)

Stable unexpected results (7)

OK /css/css-align/baseline-rules/synthesized-baseline-flexbox-001.html

FAIL [expected PASS] subtest: .wrapper 4

assert_equals: &lt;div class="wrapper"&gt; &lt;canvas&gt;&lt;/canvas&gt; &lt;div style="display: inline-flex;" class="magenta-dotted-border" data-offset-y="25"&gt; &lt;div class="border-padding-margin" data-offset-y="50"&gt;&lt;/div&gt; &lt;/div&gt; &lt;/div&gt; offsetTop expected 25 but got 0

FAIL [expected PASS] subtest: .wrapper 5

assert_equals: &lt;div class="wrapper"&gt; &lt;canvas&gt;&lt;/canvas&gt; &lt;div style="display: inline-block;" class="magenta-dotted-border" data-offset-y="25"&gt; &lt;div style="display: flex;" data-offset-y="30"&gt; &lt;div class="border-padding-margin" data-offset-y="50"&gt;&lt;/div&gt; &lt;/div&gt; &lt;/div&gt; &lt;/div&gt; offsetTop expected 25 but got 0

FAIL [expected PASS] subtest: .wrapper 6

assert_equals: &lt;div class="wrapper" style="display: flex; align-items: baseline;"&gt; &lt;canvas&gt;&lt;/canvas&gt; &lt;div style="display: inline-flex;" class="magenta-dotted-border" data-offset-y="25"&gt; &lt;div class="border-padding-margin" data-offset-y="50"&gt;&lt;/div&gt; &lt;/div&gt; &lt;/div&gt; offsetTop expected 25 but got 0

FAIL [expected PASS] subtest: .wrapper 7

assert_equals: &lt;div class="wrapper" style="display: flex; align-items: baseline;"&gt; &lt;canvas&gt;&lt;/canvas&gt; &lt;div style="display: flex;" class="magenta-dotted-border" data-offset-y="25"&gt; &lt;div class="border-padding-margin" data-offset-y="50"&gt;&lt;/div&gt; &lt;/div&gt; &lt;/div&gt; offsetTop expected 25 but got 0

OK /css/css-flexbox/overflow-auto-008.html
- PASS [expected FAIL] subtest: hbox dimensions

OK /css/css-grid/alignment/grid-align-baseline-flex-001.html

FAIL [expected PASS] subtest: .target > * 2

assert_equals: &lt;div class="inner" data-offset-y="10"&gt; &lt;div style="font-size: 10px;"&gt;&lt;span&gt;&lt;/span&gt;&lt;/div&gt; &lt;div style="font-size: 30px;"&gt;&lt;span&gt;&lt;/span&gt;&lt;/div&gt; &lt;/div&gt; offsetTop expected 10 but got 20

FAIL [expected PASS] subtest: .target > * 6

assert_equals: &lt;div class="inner" style="flex-direction: row-reverse;" data-offset-y="10"&gt; &lt;div style="font-size: 10px;"&gt;&lt;span&gt;&lt;/span&gt;&lt;/div&gt; &lt;div style="font-size: 30px;"&gt;&lt;span&gt;&lt;/span&gt;&lt;/div&gt; &lt;/div&gt; offsetTop expected 10 but got 20

FAIL [expected PASS] subtest: .target > * 25

assert_equals: &lt;div data-offset-y="25"&gt;&lt;span&gt;&lt;/span&gt;&lt;/div&gt; offsetTop expected 25 but got 115

PASS [expected FAIL] /css/css-grid/alignment/grid-baseline-003.html
OK /css/css-inline/baseline-source/baseline-source-first-001.html
- FAIL [expected PASS] subtest: .target > * 11
```
assert_equals: &lt;span data-offset-y="35"&gt;&lt;/span&gt; offsetTop expected 35 but got 80 
```
PASS [expected FAIL] /css/css-lists/list-and-flex-001.html
PASS [expected FAIL] /html/rendering/the-details-element/summary-display-inline-flex.html

github-actions · 2026-01-21T08:08:17Z

⚠️ Try run (#21200578750) failed!

components/layout/flexbox/layout.rs

lukewarlow · 2026-01-23T17:17:29Z

Note to self, push up the code accounting for flex direction reversal and simplifications after discussion with Martin.

mrobinson · 2026-01-24T00:26:25Z

components/layout/flexbox/layout.rs

 fragments: Vec<Fragment>,
 positioning_context: PositioningContext,

+ content_baselines_relative_to_margin_box: Baselines,


Can you add some rustdoc explaining the purpose of this field and how it differs from the other baseline?

Hopefully something like I've added is right?

mrobinson · 2026-01-28T16:07:37Z

There are some new failures here, but I suspect they are just exposing some of the existing bugs we discussed in our call. @lukewarlow can you please just update the expected results and then we can address the new failures later?

Signed-off-by: Luke Warlow <lwarlow@igalia.com>

Signed-off-by: Luke Warlow <lwarlow@igalia.com> Co-authored-by: Martin Robinson <mrobinson@igalia.com>

Signed-off-by: Luke Warlow <lwarlow@igalia.com>

github-actions · 2026-01-28T16:27:25Z

🔨 Triggering try run (#21446495074) for Linux (WPT)

github-actions · 2026-01-28T17:05:18Z

Test results for linux-wpt from try job (#21446495074):

Flaky unexpected result (33)

OK /IndexedDB/idbfactory-databases-opaque-origin.html
- FAIL [expected PASS] subtest: IDBFactory.databases() in non-sandboxed iframe should not reject
```
assert_equals: IDBFactory.databases() should not reject expected "no exception" but got "OperationError" 
```
OK /IndexedDB/idbfactory-open-error-properties.any.html
- PASS [expected FAIL] subtest: Properties of error event from failed open()
OK /IndexedDB/idbfactory-open-error-properties.any.worker.html
- PASS [expected FAIL] subtest: Properties of error event from failed open()
PASS [expected FAIL] /_mozilla/css/linear_gradients_reverse_a.html

OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)

FAIL [expected PASS] subtest: WebGL test #45

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #47

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

FAIL [expected PASS] subtest: WebGL test #49

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #51

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

PASS [expected FAIL] subtest: WebGL test #53
PASS [expected FAIL] subtest: WebGL test #55
PASS [expected FAIL] subtest: WebGL test #57
PASS [expected FAIL] subtest: WebGL test #59

FAIL [expected PASS] subtest: WebGL test #61

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #63

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

And 6 more unexpected results...

OK /css/css-animations/event-order.tentative.html (#39000)
- PASS [expected FAIL] subtest: Same events on pseudo-elements follow the prescribed order
TIMEOUT [expected PASS] /css/css-backgrounds/background-origin/origin-border-box.html
FAIL [expected PASS] /css/css-backgrounds/background-size-042.html
OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: setFormValue with an empty FormData should submit nothing
- PASS [expected FAIL] subtest: Newline normalization - \r\n in FormData name (urlencoded)
TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
- TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up
```
Test timed out 
```
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/multiple-iframes.https.window.html (#35176)
ERROR [expected OK] /fetch/metadata/window-open.https.sub.html (#40339)
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
CRASH [expected TIMEOUT] /html/browsers/history/the-history-interface/002.html (#12580)
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
CRASH [expected OK] /html/browsers/history/the-location-interface/assign-replace-from-iframe.html (#31638)
OK /html/browsers/windows/browsing-context-names/duplicate-name-order.html (#34623)
- PASS [expected FAIL] subtest: Duplicate name lookup order
CRASH [expected OK] /html/canvas/element/canvas-host/2d.canvas.host.size.attributes.setAttribute.whitespace.html
OK [expected TIMEOUT] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
- TIMEOUT [expected FAIL] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown
```
Test timed out 
```
OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-nav-location-replace-set-src.html (#32697)
- PASS [expected FAIL] subtest: Navigating iframe loading='lazy' and then setting src: location.replace
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out 
```
CRASH [expected OK] /html/semantics/forms/form-submission-0/form-submit-iframe-then-location-navigate.html (#29634)
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- FAIL [expected PASS] subtest: multipart/form-data: Basic test (formdata event)
```
assert_equals: expected "\r\nContent-Disposition: form-data; name=\"basic\"\r\n\r\ntest\r\n--\r\n" but got "" 
```
- FAIL [expected PASS] subtest: multipart/form-data: Basic File test (normal form)
```
assert_equals: expected "\r\nContent-Disposition: form-data; name=\"basic\"; filename=\"file-test.txt\"\r\nContent-Type: text/plain\r\n\r\n\r\n--\r\n" but got "" 
```
- PASS [expected FAIL] subtest: multipart/form-data: Basic File test (formdata event)
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- FAIL [expected PASS] subtest: text/plain: Basic File test (normal form)
```
assert_equals: expected "basic=file-test.txt\r\n" but got "" 
```
- PASS [expected FAIL] subtest: text/plain: Basic File test (formdata event)
- PASS [expected FAIL] subtest: text/plain: backslash in filename (normal form)

OK /html/semantics/scripting-1/the-script-element/execution-timing/077.html (#22139)

FAIL [expected PASS] subtest: adding several types of scripts through the DOM and removing some of them confuses scheduler

assert_array_equals: expected property 1 to be "Script #1 ran" but got "Script #3 ran" (expected array ["Script #2 ran", "Script #1 ran", "Script #3 ran", "Script #4 ran"] got ["Script #2 ran", "Script #3 ran", "Script #4 ran", "Script #1 ran"])

OK [expected ERROR] /html/user-activation/no-activation-thru-escape-key.html (#40343)
OK /mixed-content/tentative/autoupgrades/mixed-content-cors.https.sub.html (#41123)
- FAIL [expected PASS] subtest: Cross-Origin audio should get upgraded even if CORS is set
```
assert_equals: Length of other host audio is correct expected 1 but got Infinity 
```
PASS [expected FAIL] /png/apng/fcTL-dispose-none.html (#41817)
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- PASS [expected FAIL] subtest: Navigate a frame via anchor with javascript:-urls in report-only mode.
- PASS [expected TIMEOUT] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\"" 
```
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\"" 
```
OK /webxr/xrSession_features_deviceSupport.https.html (#24357)
- FAIL [expected PASS] subtest: Immersive XRSession requests with no supported device should reject
```
assert_unreached: Should have rejected: undefined Reached unreachable code 
```
ERROR [expected OK] /workers/baseurl/alpha/sharedworker-in-worker.html (#21315)

Stable unexpected results that are known to be intermittent (32)

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() { cursor.continuePrimaryKey(2, 2); }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.worker.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() { cursor.continuePrimaryKey(2, 2); }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbrequest-onupgradeneeded.any.html (#38895)
- PASS [expected FAIL] subtest: transaction oncomplete ordering relative to open request onsuccess
OK /IndexedDB/idbrequest-onupgradeneeded.any.worker.html (#38971)
- PASS [expected FAIL] subtest: transaction oncomplete ordering relative to open request onsuccess

OK /IndexedDB/key-conversion-exceptions.any.html (#39305)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; { receiver[method](key); }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] subtest: IDBCursor update() method with throwing/invalid keys

assert_throws_exactly: throwing getter should rethrow during clone function "() =&gt; { cursor.update(value); }" threw object "TypeError: cursor.update is not a function" but we expected it to throw object "getter: throwing from getter"

OK /IndexedDB/key-conversion-exceptions.any.worker.html (#39284)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; { receiver[method](key); }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] subtest: IDBCursor update() method with throwing/invalid keys

assert_throws_exactly: throwing getter should rethrow during clone function "() =&gt; { cursor.update(value); }" threw object "TypeError: cursor.update is not a function" but we expected it to throw object "getter: throwing from getter"

OK /IndexedDB/transaction-deactivation-timing.any.html (#38772)
- PASS [expected FAIL] subtest: New transactions are deactivated before next task
- PASS [expected FAIL] subtest: New transactions from microtask are deactivated before next task
OK /_mozilla/css/offset_properties_inline.html (#40543)
- PASS [expected FAIL] subtest: offsetTop
- PASS [expected FAIL] subtest: offsetLeft
FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out 
```
OK /css/css-cascade/layer-font-face-override.html (#35935)
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 1
OK /css/css-fonts/generic-family-keywords-001.html (#37467)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted generic(nastaliq)
```
assert_equals: quoted generic(nastaliq) matches @font-face rule expected 50 but got 30 
```
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted cursive (drawing text in a canvas)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted fantasy (drawing text in a canvas)
```
assert_equals: quoted fantasy matches @font-face rule expected 125 but got 40 
```
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted system-ui (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(nastaliq) (drawing text in a canvas)
OK /css/cssom-view/offsetTopLeft-border-box.html (#40826)
- PASS [expected FAIL] subtest: container: 0
- PASS [expected FAIL] subtest: container: 1
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/sandboxed-iframe.https.window.html (#41704)

OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)

FAIL [expected PASS] subtest: sec-fetch-mode

promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."

FAIL [expected PASS] subtest: sec-fetch-user

promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."

OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers." 
```
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination
OK [expected ERROR] /focus/focus-event-after-switching-iframes.sub.html (#40368)
CRASH [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
CRASH [expected TIMEOUT] /html/browsers/history/the-location-interface/location_replace_session_history.html (#41896)
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- PASS [expected TIMEOUT] subtest: Non-HTMLElement should not support autofocus
- FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus
```
assert_equals: expected Element node &lt;div autofocus=""&gt;&lt;/div&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;/body&gt; 
```
- TIMEOUT [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
```
Test timed out 
```
TIMEOUT /html/semantics/embedded-content/media-elements/autoplay-default-feature-policy.https.sub.html (#41193)
- TIMEOUT [expected PASS] subtest: Default "autoplay" feature policy ["self"] allows same-origin iframes.
```
Test timed out 
```
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
- PASS [expected FAIL] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
- PASS [expected FAIL] subtest: Reload fetchStart > Original fetchStart
OK /preload/prefetch-document.html (#37210)
- FAIL [expected PASS] subtest: different-site document prefetch with 'as=document' should not be consumed
```
assert_equals: expected 2 but got 1 
```
OK /resource-timing/buffer-full-add-then-clear.html (#40819)
- FAIL [expected PASS] subtest: Test that if the buffer is cleared after entries were added to the secondary buffer, those entries make it into the primary one
```
assert_equals: Number of entries does not match the expected value. expected 3 but got 0 
```
OK [expected TIMEOUT] /resource-timing/test_resource_timing.html (#25720)
- PASS [expected TIMEOUT] subtest: window.performance.getEntriesByName() and window.performance.getEntriesByNameType() return same data (link)
- FAIL [expected NOTRUN] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (link)
```
assert_equals: expected 3.599999999999998 but got 3.59 
```
- FAIL [expected NOTRUN] subtest: PerformanceEntry has correct order of timing attributes (link)
```
assert_greater_than_equal: domainLookupEnd after domainLookupStart expected a number greater than or equal to 31.12 but got 0 
```
- FAIL [expected NOTRUN] subtest: PerformanceEntry has correct network transfer attributes (link)
```
assert_equals: encodedBodySize size expected 44 but got 0 
```
- FAIL [expected NOTRUN] subtest: PerformanceEntry has correct protocol attribute (link)
```
assert_equals: expected protocol expected "http/1.1" but got "" 
```
OK [expected TIMEOUT] /resource-timing/test_resource_timing.https.html (#25216)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
```
assert_equals: expected 14.940000000000012 but got 14.94 
```
- PASS [expected TIMEOUT] subtest: window.performance.getEntriesByName() and window.performance.getEntriesByNameType() return same data (link)
- FAIL [expected NOTRUN] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (link)
```
assert_equals: expected 12.47999999999999 but got 12.47 
```
- FAIL [expected NOTRUN] subtest: PerformanceEntry has correct order of timing attributes (link)
```
assert_greater_than_equal: domainLookupEnd after domainLookupStart expected a number greater than or equal to 115.73 but got 0 
```
- FAIL [expected NOTRUN] subtest: PerformanceEntry has correct network transfer attributes (link)
```
assert_equals: encodedBodySize size expected 44 but got 0 
```
- FAIL [expected NOTRUN] subtest: PerformanceEntry has correct protocol attribute (link)
```
assert_equals: expected protocol expected "http/1.1" but got "" 
```
TIMEOUT [expected OK] /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- TIMEOUT [expected PASS] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
```
Test timed out 
```
- NOTRUN [expected PASS] subtest: Navigate a window via anchor with javascript:-urls w/ default policy in report-only mode.
- NOTRUN [expected PASS] subtest: Navigate a frame via anchor with javascript:-urls in enforcing mode.
OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe

github-actions · 2026-01-28T17:06:31Z

✨ Try run (#21446495074) succeeded.

lukewarlow requested review from Loirooriol and mrobinson as code owners January 20, 2026 23:48

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 20, 2026

TimvdLippe added the T-linux-wpt Do a try run of the WPT label Jan 21, 2026

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Jan 21, 2026

Loirooriol reviewed Jan 21, 2026

View reviewed changes

components/layout/flexbox/layout.rs Outdated Show resolved Hide resolved

lukewarlow force-pushed the flexbox-inline-baseline-fix branch from 4cca2c8 to 81096db Compare January 22, 2026 14:03

lukewarlow marked this pull request as draft January 22, 2026 14:07

lukewarlow force-pushed the flexbox-inline-baseline-fix branch 2 times, most recently from 18f5172 to b34e158 Compare January 23, 2026 15:48

lukewarlow marked this pull request as ready for review January 23, 2026 17:32

lukewarlow force-pushed the flexbox-inline-baseline-fix branch from 6b991a7 to e875ea6 Compare January 23, 2026 17:33

mrobinson approved these changes Jan 24, 2026

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jan 24, 2026

mrobinson changed the title ~~Fix baseline propagation from flex containers~~ layout: Properly propagate baselines of flex items that do not participate in baseline alignment Jan 24, 2026

mrobinson force-pushed the flexbox-inline-baseline-fix branch from e875ea6 to 9109333 Compare January 28, 2026 10:36

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 28, 2026

lukewarlow force-pushed the flexbox-inline-baseline-fix branch from 9109333 to e7c5cc8 Compare January 28, 2026 11:17

mrobinson approved these changes Jan 28, 2026

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jan 28, 2026

mrobinson added this pull request to the merge queue Jan 28, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 28, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 28, 2026

servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jan 28, 2026

lukewarlow and others added 4 commits January 28, 2026 16:14

Fix baseline propagation from flex containers

137dee5

Signed-off-by: Luke Warlow <lwarlow@igalia.com>

Adjustments

3c56eae

Signed-off-by: Luke Warlow <lwarlow@igalia.com> Co-authored-by: Martin Robinson <mrobinson@igalia.com>

Add rust docs

371daba

Signed-off-by: Luke Warlow <lwarlow@igalia.com>

Adjust baseline expectations

2dd4757

Signed-off-by: Luke Warlow <lwarlow@igalia.com>

lukewarlow force-pushed the flexbox-inline-baseline-fix branch from e7c5cc8 to 2dd4757 Compare January 28, 2026 16:26

servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Jan 28, 2026

lukewarlow added the T-linux-wpt Do a try run of the WPT label Jan 28, 2026

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Jan 28, 2026

mrobinson enabled auto-merge January 28, 2026 16:27

mrobinson added this pull request to the merge queue Jan 28, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 28, 2026

Merged via the queue into servo:main with commit 0da3103 Jan 28, 2026
69 checks passed

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 28, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

layout: Properly propagate baselines of flex items that do not participate in baseline alignment#42038

layout: Properly propagate baselines of flex items that do not participate in baseline alignment#42038
mrobinson merged 4 commits intoservo:mainfrom
lukewarlow:flexbox-inline-baseline-fix

lukewarlow commented Jan 20, 2026 •

edited

Loading

lukewarlow commented Jan 20, 2026

github-actions bot commented Jan 21, 2026

github-actions bot commented Jan 21, 2026

github-actions bot commented Jan 21, 2026

Uh oh!

lukewarlow commented Jan 23, 2026

mrobinson Jan 24, 2026

lukewarlow Jan 28, 2026

Uh oh!

mrobinson commented Jan 28, 2026

github-actions bot commented Jan 28, 2026

github-actions bot commented Jan 28, 2026

github-actions bot commented Jan 28, 2026

Uh oh!

Labels

5 participants

Uh oh!

Conversation

lukewarlow commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

lukewarlow commented Jan 20, 2026

github-actions bot commented Jan 21, 2026

github-actions bot commented Jan 21, 2026

github-actions bot commented Jan 21, 2026

Uh oh!

lukewarlow commented Jan 23, 2026

mrobinson Jan 24, 2026

Choose a reason for hiding this comment

lukewarlow Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

mrobinson commented Jan 28, 2026

github-actions bot commented Jan 28, 2026

github-actions bot commented Jan 28, 2026

github-actions bot commented Jan 28, 2026

Uh oh!

Labels

5 participants

lukewarlow commented Jan 20, 2026 •

edited

Loading