Fix inline assign and access #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sirbrillig force-pushed the fix/argument-assign-scope branch 3 times, most recently from d0360df to ea4581f Compare This is an example of the assignment scope bug mentioned in #13
sirbrillig force-pushed the fix/argument-assign-scope branch from ea4581f to ee9d6e6 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #13
When a variable is found, we use
findWhereAssignExecuted()to consider where to mark that variable as "ready to be used" (eg: this is illegal if$foois not defined:$foo = $foo + 1;). It checks for semicolons or closing parenthesis and returns whichever comes first.In this case, the expression
($foo = 1, $foo)uses the variable before either a semicolon or a parenthesis; instead it uses a comma.This PR adds
T_COMMAas a possible ending token as well.