Add sniff codes for array assignment shortcut #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sirbrillig deleted the add-sniff-codes-for-array-assignment-shortcut branch This was referenced Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This replaces the
UndefinedVariablesniff code withUndefinedArrayVariableif the variable is an "array push shortcut" (I don't know of a better name for it):$x[] = 5;Also, when marking such a variable, this sniff considers that variable defined at that point going forward. (This will prevent future uses of the same variable from being reported as undefined.)
Fixes #98