Fix array_walk pass-by-reference in 2.x #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sirbrillig changed the title 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When marking a variable as used, we also check to see if that variable is a reference to another variable, and if so we mark the referenced variable as used also. However, it's possible to have a reference variable that doesn't reference anything until runtime.
Because
markVariableAssignmentwill create a variable record if one does not exist, this caused non-existent variable records to be created for unbound reference variables. These references (since they didn't refer to a real variable) were always unused. This caused false positive warnings about unused variables.This PR fixes the problem by making sure that the referenced variable exists before calling
markVariableAssignment.Fixes #215