Treat writing to a by-reference foreach loop variable as a read #221
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When a foreach loop variable (eg:
$fooinforeach($data as $foo)) is a reference (eg:foreach($data as &$foo)), then any write to that variable should also count as a read, since it has the side-effect of modifying the original data (eg:$datainforeach($data as &$foo)).Fixes part of #219