Workloadapi FetchX509SVID logs selectors at info on success#6254
Closed
zmt wants to merge 2 commits intospiffe:mainfrom
Closed
Workloadapi FetchX509SVID logs selectors at info on success#6254zmt wants to merge 2 commits intospiffe:mainfrom
zmt wants to merge 2 commits intospiffe:mainfrom
Conversation
Signed-off-by: Zack Train <ztrain@uber.com>
3 tasks
Member
| We discussed this in the SPIRE Contributor call and concluded that logging a “Fetched X.509 SVID” message at the Info level each time an X509-SVID is fetched could overwhelm the agent logs. This might be a good opportunity to introduce Audit Logging in the agent, similar to what we already have in the server. That way, this event could be captured as an audit log, allowing users to opt in if they want to track fetched X.509 SVIDs. Even though selectors may change after attestation, I think it’s still valuable to include selectors in the audit log entry. Users should be able to have the selectors redacted. |
3 tasks
Contributor Author
| I'm going to abandon this for now. I like the suggestion of adding audit log capability to spire-agent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
Agent logging on successful FetchX509SVID.
Description of change
Agent logs at info level with selectors on successful FetchX509SVID.
Initial follow-up to discussion in #6179, relates to #2651, and probably depends on #2666 (closed unplanned).