Support setting gzip_compression flag for log forwarder #794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
hvaghani221 suggested changes Jul 29, 2022
Contributor
hvaghani221 left a comment
hvaghani221 left a comment There was a problem hiding this comment.
I think gzip_compression should defaults to false
Contributor
| Can you also fix lint test failures? |
Contributor Author
Fair. Will adjust
Yup. Will push in a bit. |
Contributor
| I cannot merge it until splunk_hec plugin is released |
hvaghani221 approved these changes Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Functionality depends on an upstream change
splunk/fluentd-hec#250
Proposed changes
Support potential new flag for gzip compression from:
splunk/fluentd-hec#250
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.Hoping this PR might help with visibility on the upstream change.