Remove JUnit 4 references from test slice annotations javadoc #48257
+0 −54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Remove outdated JUnit 4 usage instructions from javadoc comments in all test slice annotations (@DataJpaTest, @WebMvcTest, etc.). These annotations now only work with JUnit 5 (Jupiter) via @ExtendWith(SpringExtension.class), making the JUnit 4 instructions obsolete and potentially confusing for users. See spring-projectsgh-47228 Signed-off-by: ramzeta <ramzeta@users.noreply.github.com>
spring-projects-issues added the status: waiting-for-triage 
philwebb added type: documentation 
Member
| Thanks for the PR @ramzeta but the work is already done. As shown in the original issue it was reverted but will be reapplied when we decide in which milestone we want to merge this. |
snicoll added status: declined 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #47228
Summary
This PR removes outdated JUnit 4 usage instructions from javadoc comments in all test slice annotations.
Changes
Removed the following paragraph from 18 test annotation classes:
These annotations now only work with JUnit 5 (Jupiter) via
@ExtendWith(SpringExtension.class), making the JUnit 4 instructions obsolete and potentially confusing for users.Affected Annotations
@DataCassandraTest@DataCouchbaseTest@DataElasticsearchTest@DataJdbcTest@DataJpaTest@DataLdapTest@DataMongoTest@DataNeo4jTest@DataR2dbcTest@DataRedisTest@JdbcTest@JooqTest@JsonTest@RestClientTest@WebClientTest@WebFluxTest@WebMvcTest@WebServiceClientTest