Added query fetches search for join existence when applying JPA ordering.#2434
Open
AntonMolganov wants to merge 4 commits intospring-projects:mainfrom
Open
Added query fetches search for join existence when applying JPA ordering.#2434AntonMolganov wants to merge 4 commits intospring-projects:mainfrom
AntonMolganov wants to merge 4 commits intospring-projects:mainfrom
Conversation
spring-projects-issues added the status: waiting-for-triage 
Contributor
| The "See" link 404s, should that go to #2253? |
Author
Fixed pull request message. |
schauder requested changes Feb 9, 2022
Contributor
schauder left a comment
schauder left a comment There was a problem hiding this comment.
We would need an integration test to go with this. UserRepositoryTests would probably a good home for that.
schauder added status: waiting-for-feedback 
Indentation in testcases (spaces -> tabs). Additional imports.
The Auditable interface introduces Optional getters, which when combined with Query by Example results in cryptic errors. By ignoring a probe's field that contains an Optional.empty, Query by Example works properly. NOTE: This fix actually tests outside the originally detected scope of Auditable, verifying that ALL Optional.empty() fields are properly handled. Closes spring-projects#2176 Original pull request spring-projects#2401
Removed Given/When/Then comments. They are of limited use, especially since it is debatable what belongs in which section. See spring-projects#2176 Original pull request spring-projects#2401
AntonMolganov force-pushed the bugfix-2253 branch from d76bce7 to 1d1be82 Compare 
mp911de force-pushed the main branch 2 times, most recently from 52ee55f to 61e6d36 Compare This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2253
See #2253