- Notifications
You must be signed in to change notification settings - Fork 38.9k
Open
Labels
status: waiting-for-triageAn issue we've not yet triaged or decided onAn issue we've not yet triaged or decided on
Description
I get the following output when logging my errors. my apiKey is on full display, I can't use x-api-key header (I don't control the endpoint).
Error has been observed at the following site(s):
*__checkpoint ⇢ Body from POST https://api.example.com/resource?apiKey=[apiKey] [DefaultClientResponse]
When debugging this seems to be the source:
Line 111 in b31f78d
| httpResponse, this.strategies, logPrefix, httpMethod.name() + " " + url, |
The function:
WebClientUtils.getRequestDescription(this.request.getMethod(), this.request.getURI()),
() -> this.request);
Is used in most other checkpoint, notably:
DefaultClientResponseBuilder
@Override public ClientResponse build() { ClientHttpResponse httpResponse = new BuiltClientHttpResponse( this.statusCode, this.headers, this.cookies, this.body, this.originalResponse); return new DefaultClientResponse(httpResponse, this.strategies, this.originalResponse != null ? this.originalResponse.logPrefix() : "", WebClientUtils.getRequestDescription(this.request.getMethod(), this.request.getURI()), () -> this.request); }perhaps it is missing here as well? Or is this intentional?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
status: waiting-for-triageAn issue we've not yet triaged or decided onAn issue we've not yet triaged or decided on