Open
Conversation
Author
| @JakeWharton @codebutler hello ?anyone there |
liu-wanshun approved these changes Oct 9, 2023
elliptic1 reviewed Oct 23, 2023
| import java.lang.reflect.ParameterizedType | ||
| import java.lang.reflect.Type | ||
| import kotlin.coroutines.CoroutineContext | ||
| import org.junit.Assert.* |
There was a problem hiding this comment.
Don't use star imports if this project wasn't already using them
elliptic1 reviewed Oct 23, 2023
| import java.lang.reflect.Type; | ||
| import javax.annotation.Nullable; | ||
| | ||
| import kotlin.Result; |
There was a problem hiding this comment.
extra space and new import not alphabetized
elliptic1 reviewed Oct 23, 2023
| return try { | ||
| val response = delegate.execute() | ||
| val result = if (response.isSuccessful) { | ||
| Result.success(response.body()!!) |
There was a problem hiding this comment.
Don't use !! - there is always a better way to fail gracefully into the Result.failure case if this is null.
elliptic1 reviewed Oct 23, 2023
| } | ||
| Response.success(result) | ||
| } catch (e: IOException) { | ||
| Response.success(Result.failure(e)) |
There was a problem hiding this comment.
This does the same job as the more general Exception case, so it's not needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add the ResultCallAdapter to return Result to wrap the outcome (success/failure) of a retrofit call, instead of returning a value or throwing an exception. #3558
like
@get("me")
suspend fun getUser(): Result
all the testcase in Kotlin-test package and retrofit-adapter moudle's test case has been passed