Conversation
sschuberth force-pushed the jackson3-converter branch from 6d5395d to e7dffaf Compare 
| Thanks! This mostly looks good from a quick check. I want to familiarize myself with this major release, but otherwise I hope to get this merged this month and released by EOY. |
sschuberth force-pushed the jackson3-converter branch from e7dffaf to 4d79dea Compare | I ran |
| Mind approving the workflow once more to verify that tests now pass, @JakeWharton? |
sschuberth force-pushed the jackson3-converter branch from 4d79dea to 9f78f8c Compare
I've rebased this to catch-up with the new required |
Is there still a chance to get this merged before the end of the year? |
Happy new year ping 😉 |
| I have quit this company a few months ago so any work I do here is entirely volunteer work. I appreciate the contribution, but it'll still probably be a few weeks until I look at this project again. |
| Hi! I'm also quite interested in this PR being merged. Is @JakeWharton the only maintainer of this project? |
| The design of Retrofit is such that you do not need this to be merged to be unblocked. You can have your own Jackson 3 converter living in your codebase for the time being. And yes, it's basically just me. |
sschuberth force-pushed the jackson3-converter branch from 9f78f8c to f6b073d Compare 
sschuberth force-pushed the jackson3-converter branch from f6b073d to 5f64562 Compare This was implicitly available as a transitive dependency, but that should not be relied on. It is required for `JsonAutoDetect.Visibility.ANY`. Note that `jackson-annotations` is versioned independently of the rest of Jackson and does not use a path-level version suffix.
sschuberth force-pushed the jackson3-converter branch from 5f64562 to 64d8c19 Compare ...verters/jackson3/src/main/java/retrofit2/converter/jackson3/JacksonStreamingRequestBody.java Show resolved Hide resolved
...verters/jackson3/src/main/java/retrofit2/converter/jackson3/JacksonRequestBodyConverter.java Outdated Show resolved Hide resolved
...erters/jackson3/src/main/java/retrofit2/converter/jackson3/JacksonResponseBodyConverter.java Outdated Show resolved Hide resolved
...erters/jackson3/src/main/java/retrofit2/converter/jackson3/JacksonResponseBodyConverter.java Show resolved Hide resolved
sschuberth force-pushed the jackson3-converter branch 2 times, most recently from 530062a to be1740e Compare This mostly copies the existing Jackson (2) converter and does the necessary migration [1]. Note that Jackson 3 requires Java 17. [1]: https://github.com/FasterXML/jackson/blob/main/jackson3/MIGRATING_TO_JACKSON_3.md
sschuberth force-pushed the jackson3-converter branch from be1740e to 8b481ce Compare 
danrebati-fujitsu left a comment
danrebati-fujitsu left a comment There was a problem hiding this comment.
Looks good to me, though I am not a maintainer of this project. I'm just a passer-by 🙂
Thanks anyway for the review, you had some good findings there! |
4 participants
CHANGELOG.md's "Unreleased" section has been updated, if applicable.