Move to monorepo structure by pedropombeiro · Pull Request #1684 · status-im/status-go

pedropombeiro · 2019-11-20T13:27:40Z

This PR moves status-go into a monorepo structure by folding in status-protocol-go into the protocol subdirectory.

Changes:

github.com/status-im/status-protocol-go -> github.com/status-im/status-go/protocol
package protocol -> package v1protocol
package statusproto -> package protocol

ghost · 2019-11-20T13:27:46Z

Pull Request Checklist

Have you updated the documentation, if impacted (e.g. docs.status.im)?

ghost · 2019-11-20T13:28:48Z

status-go/vendor/github.com/tyler-smith/go-bip39/Gopkg.lock changed. Pinging @adambabik, @mandrigin, and @corpetty

ghost · 2019-11-20T13:31:00Z

status-go/vendor/github.com/tyler-smith/go-bip39/Gopkg.lock changed. Pinging @adambabik, @mandrigin, and @corpetty

ghost · 2019-11-20T13:42:39Z

status-go/vendor/github.com/tyler-smith/go-bip39/Gopkg.lock changed. Pinging @adambabik, @mandrigin, and @corpetty

status-im-auto · 2019-11-20T13:52:05Z

Jenkins Builds

Click to see older builds (73)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`8686cda`	#1	2019-11-20 13:52:05	~19 sec	`linux`	📄`log`
❌	`8686cda`	#1	2019-11-20 13:53:31	~1 min	`ios`	📄`log`
❌	`8686cda`	#1	2019-11-20 13:53:32	~1 min	`android`	📄`log`

✔️	`fc2498b`	#2	2019-11-20 14:28:45	~33 sec	`linux`	📦`zip`
❌	`fc2498b`	#2	2019-11-20 14:30:01	~1 min	`android`	📄`log`
❌	`fc2498b`	#2	2019-11-20 14:30:03	~1 min	`ios`	📄`log`

✔️	`fab7a16`	#3	2019-11-20 14:44:51	~22 sec	`linux`	📦`zip`
❌	`fab7a16`	#3	2019-11-20 14:44:56	~29 sec	`ios`	📄`log`
❌	`fab7a16`	#3	2019-11-20 14:46:03	~1 min	`android`	📄`log`

❌	`65bfb4b`	#4	2019-11-20 15:05:41	~25 sec	`android`	📄`log`
✔️	`65bfb4b`	#4	2019-11-20 15:05:46	~27 sec	`linux`	📦`zip`
❌	`65bfb4b`	#4	2019-11-20 15:05:50	~31 sec	`ios`	📄`log`

❌	`7284c7e`	#5	2019-11-20 15:17:51	~22 sec	`android`	📄`log`
❌	`7284c7e`	#5	2019-11-20 15:17:54	~23 sec	`ios`	📄`log`
✔️	`7284c7e`	#5	2019-11-20 15:18:04	~31 sec	`linux`	📦`zip`

✔️	`075cb72`	#6	2019-11-20 15:25:08	~26 sec	`linux`	📦`zip`
❌	`075cb72`	#6	2019-11-20 15:25:09	~28 sec	`ios`	📄`log`
❌	`075cb72`	#6	2019-11-20 15:26:15	~1 min	`android`	📄`log`

❌	`773b25e`	#7	2019-11-20 15:37:04	~27 sec	`ios`	📄`log`
✔️	`773b25e`	#7	2019-11-20 15:37:09	~31 sec	`linux`	📦`zip`
❌	`773b25e`	#7	2019-11-20 15:37:54	~1 min	`android`	📄`log`

✔️	`9cbd6cf`	#8	2019-11-20 15:42:02	~18 sec	`linux`	📦`zip`
❌	`9cbd6cf`	#8	2019-11-20 15:42:07	~26 sec	`ios`	📄`log`
❌	`9cbd6cf`	#8	2019-11-20 15:43:02	~1 min	`android`	📄`log`

✔️	`82deb06`	#9	2019-11-20 15:46:51	~18 sec	`linux`	📦`zip`
❌	`82deb06`	#9	2019-11-20 15:46:56	~25 sec	`ios`	📄`log`
❌	`82deb06`	#9	2019-11-20 15:47:49	~1 min	`android`	📄`log`

❌	`ba9d593`	#10	2019-11-20 15:51:14	~25 sec	`ios`	📄`log`
✔️	`ba9d593`	#10	2019-11-20 15:51:15	~24 sec	`linux`	📦`zip`
❌	`ba9d593`	#10	2019-11-20 15:52:08	~1 min	`android`	📄`log`

✔️	`b1e63ca`	#11	2019-11-20 15:52:09	~20 sec	`linux`	📦`zip`
❌	`b1e63ca`	#11	2019-11-20 15:52:14	~26 sec	`ios`	📄`log`
❌	`b1e63ca`	#11	2019-11-20 15:53:30	~1 min	`android`	📄`log`

❌	`74cabdc`	#12	2019-11-20 15:53:54	~32 sec	`ios`	📄`log`
✔️	`74cabdc`	#12	2019-11-20 15:54:05	~34 sec	`linux`	📦`zip`
❌	`74cabdc`	#12	2019-11-20 15:55:08	~1 min	`android`	📄`log`

❌	`6b02c04`	#13	2019-11-20 18:42:58	~27 sec	`ios`	📄`log`
✔️	`6b02c04`	#13	2019-11-20 18:43:03	~31 sec	`linux`	📦`zip`
❌	`6b02c04`	#13	2019-11-20 18:43:51	~1 min	`android`	📄`log`

✔️	`b130631`	#14	2019-11-20 18:45:41	~21 sec	`linux`	📦`zip`
❌	`b130631`	#14	2019-11-20 18:45:43	~25 sec	`ios`	📄`log`
❌	`b130631`	#14	2019-11-20 18:46:36	~1 min	`android`	📄`log`

✔️	`ff8da31`	#15	2019-11-20 18:55:39	~23 sec	`linux`	📦`zip`
✔️	`ff8da31`	#15	2019-11-20 18:59:21	~4 min	`ios`	📦`zip`
❌	`ff8da31`	#15	2019-11-20 19:00:33	~5 min	`android`	📄`log`

✔️	`718aa3f`	#16	2019-11-21 09:00:41	~30 sec	`linux`	📦`zip`
✔️	`718aa3f`	#16	2019-11-21 09:03:55	~3 min	`ios`	📦`zip`
❌	`718aa3f`	#16	2019-11-21 09:05:16	~5 min	`android`	📄`log`

✔️	`ba37148`	#17	2019-11-21 09:03:00	~22 sec	`linux`	📦`zip`
✔️	`ba37148`	#17	2019-11-21 09:07:02	~3 min	`ios`	📦`zip`
❌	`ba37148`	#17	2019-11-21 09:10:21	~5 min	`android`	📄`log`

✔️	`38fb08d`	#18	2019-11-21 09:34:47	~19 sec	`linux`	📦`zip`
✔️	`38fb08d`	#18	2019-11-21 09:37:21	~2 min	`ios`	📦`zip`
❌	`38fb08d`	#18	2019-11-21 09:40:31	~6 min	`android`	📄`log`

✔️	`2ad6134`	#19	2019-11-21 09:36:11	~36 sec	`linux`	📦`zip`
✔️	`2ad6134`	#19	2019-11-21 09:39:58	~2 min	`ios`	📦`zip`
❌	`2ad6134`	#19	2019-11-21 09:45:22	~4 min	`android`	📄`log`

✔️	`2fa6e74`	#20	2019-11-21 09:57:44	~36 sec	`linux`	📦`zip`
✔️	`2fa6e74`	#20	2019-11-21 09:59:41	~2 min	`ios`	📦`zip`
✔️	`2fa6e74`	#20	2019-11-21 10:02:44	~5 min	`android`	📦`aar`

✔️	`8533995`	#21	2019-11-21 10:24:42	~25 sec	`linux`	📦`zip`
✔️	`8533995`	#21	2019-11-21 10:29:21	~5 min	`ios`	📦`zip`
✔️	`8533995`	#21	2019-11-21 10:30:00	~5 min	`android`	📦`aar`

✔️	`74f24bf`	#22	2019-11-21 12:38:40	~21 sec	`linux`	📦`zip`
✔️	`74f24bf`	#22	2019-11-21 12:40:57	~2 min	`ios`	📦`zip`

✔️	`cd97073`	#23	2019-11-21 13:08:25	~37 sec	`linux`	📦`zip`
✔️	`cd97073`	#23	2019-11-21 13:11:39	~3 min	`ios`	📦`zip`

✔️	`2bf8ff7`	#24	2019-11-21 14:40:32	~48 sec	`linux`	📦`zip`
✔️	`2bf8ff7`	#24	2019-11-21 14:45:03	~5 min	`ios`	📦`zip`
✔️	`2bf8ff7`	#24	2019-11-21 14:45:53	~6 min	`android`	📦`aar`

✔️	`68452b7`	#25	2019-11-21 14:58:48	~50 sec	`linux`	📦`zip`
✔️	`68452b7`	#25	2019-11-21 15:01:30	~3 min	`ios`	📦`zip`
✔️	`68452b7`	#25	2019-11-21 15:03:36	~5 min	`android`	📦`aar`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`0a22eb0`	#26	2019-11-21 15:28:05	~43 sec	`linux`	📦`zip`
✔️	`0a22eb0`	#26	2019-11-21 15:29:51	~2 min	`ios`	📦`zip`
✔️	`0a22eb0`	#26	2019-11-21 15:34:04	~6 min	`android`	📦`aar`

✔️	`fd0333a`	#27	2019-11-21 15:45:21	~49 sec	`linux`	📦`zip`
✔️	`fd0333a`	#27	2019-11-21 15:50:03	~5 min	`ios`	📦`zip`
✔️	`fd0333a`	#27	2019-11-21 15:50:21	~5 min	`android`	📦`aar`

ghost · 2019-11-20T13:52:41Z

status-go/vendor/github.com/tyler-smith/go-bip39/Gopkg.lock changed. Pinging @adambabik, @mandrigin, and @corpetty

ghost · 2019-11-20T14:29:07Z

status-go/vendor/github.com/tyler-smith/go-bip39/Gopkg.lock changed. Pinging @adambabik, @mandrigin, and @corpetty

ghost · 2019-11-20T14:45:26Z

status-go/vendor/github.com/tyler-smith/go-bip39/Gopkg.lock changed. Pinging @adambabik, @mandrigin, and @corpetty

ghost · 2019-11-20T15:18:24Z

status-go/vendor/github.com/tyler-smith/go-bip39/Gopkg.lock changed. Pinging @adambabik, @mandrigin, and @corpetty

ghost · 2019-11-20T15:25:37Z

status-go/vendor/github.com/tyler-smith/go-bip39/Gopkg.lock changed. Pinging @adambabik, @mandrigin, and @corpetty

ghost · 2019-11-20T15:37:33Z

status-go/vendor/github.com/tyler-smith/go-bip39/Gopkg.lock changed. Pinging @adambabik, @mandrigin, and @corpetty

ghost · 2019-11-20T15:42:38Z

status-go/vendor/github.com/tyler-smith/go-bip39/Gopkg.lock changed. Pinging @adambabik, @mandrigin, and @corpetty

ghost · 2019-11-20T15:47:26Z

status-go/vendor/github.com/tyler-smith/go-bip39/Gopkg.lock changed. Pinging @adambabik, @mandrigin, and @corpetty

ghost · 2019-11-20T15:51:45Z

status-go/vendor/github.com/tyler-smith/go-bip39/Gopkg.lock changed. Pinging @adambabik, @mandrigin, and @corpetty

ghost · 2019-11-20T15:52:45Z

status-go/vendor/github.com/tyler-smith/go-bip39/Gopkg.lock changed. Pinging @adambabik, @mandrigin, and @corpetty

ghost · 2019-11-20T18:46:16Z

status-go/vendor/github.com/tyler-smith/go-bip39/Gopkg.lock changed. Pinging @adambabik, @mandrigin, and @corpetty

pedropombeiro · 2019-11-21T11:14:26Z

This PR seems to be ready for review, only CodeClimate is failing for some unknown reason, but that doesn't prevent merging.

jakubgs

I don't really see why we would put all the normal contents of status-go in a status-go subfolder. If we are treating this as a mono-repo into which we want to integrate status-protocol-go then we shouldn't be modifying the structure of status-go.

I say simply put contents of status-protocol-go at the root of this repo in a protocol folder and rename the package from statusproto to just protocol. That will make it github.com/status-im/status-go/protocol, which is much cleaner. @adambabik thoughts?

ghost · 2019-11-21T14:39:59Z

status-protocol/vendor/github.com/tyler-smith/go-bip39/Gopkg.lock changed. Pinging @adambabik, @mandrigin, and @corpetty

ghost · 2019-11-21T14:40:41Z

status-protocol/vendor/github.com/tyler-smith/go-bip39/Gopkg.lock changed. Pinging @adambabik, @mandrigin, and @corpetty

pedropombeiro · 2019-11-21T14:41:45Z

@jakubgs yeah, at first I didn't like seeing status-protocol-go getting lost among the dozens of existing folders, but I guess it makes more sense to leave status-go at the top level. I've pushed that change.

ghost · 2019-11-21T14:58:16Z

protocol/vendor/github.com/tyler-smith/go-bip39/Gopkg.lock changed. Pinging @adambabik, @mandrigin, and @corpetty

ghost · 2019-11-21T15:25:38Z

protocol/vendor/github.com/tyler-smith/go-bip39/Gopkg.lock changed. Pinging @adambabik, @mandrigin, and @corpetty

ghost · 2019-11-21T15:25:53Z

protocol/vendor/github.com/tyler-smith/go-bip39/Gopkg.lock changed. Pinging @adambabik, @mandrigin, and @corpetty

ghost · 2019-11-21T15:27:38Z

protocol/vendor/github.com/tyler-smith/go-bip39/Gopkg.lock changed. Pinging @adambabik, @mandrigin, and @corpetty

jakubgs

ghost · 2019-11-21T15:44:50Z

protocol/vendor/github.com/tyler-smith/go-bip39/Gopkg.lock changed. Pinging @adambabik, @mandrigin, and @corpetty

pedropombeiro · 2019-11-21T15:44:52Z

Merging once build passes

Move to a monorepo structure with submodules - Rename status-protocol-go to status-go/protocol Signed-off-by: Jakub Sokołowski <jakub@status.im>

ghost · 2020-01-15T13:58:36Z

protocol/vendor/github.com/tyler-smith/go-bip39/Gopkg.lock changed. Pinging @adambabik and @corpetty

pedropombeiro requested review from adambabik, cammellos and jakubgs November 20, 2019 13:27

pedropombeiro self-assigned this Nov 20, 2019

pedropombeiro force-pushed the monorepo branch from 00b4435 to 914e4de Compare November 20, 2019 13:29

pedropombeiro force-pushed the monorepo branch from 914e4de to 52d1f19 Compare November 20, 2019 13:41

pedropombeiro force-pushed the monorepo branch from 52d1f19 to 8686cda Compare November 20, 2019 13:51

pedropombeiro force-pushed the monorepo branch from 8686cda to fc2498b Compare November 20, 2019 14:27

pedropombeiro force-pushed the monorepo branch from fc2498b to fab7a16 Compare November 20, 2019 14:44

pedropombeiro force-pushed the monorepo branch 2 times, most recently from 65bfb4b to 7284c7e Compare November 20, 2019 15:17

pedropombeiro force-pushed the monorepo branch from 9cbd6cf to 82deb06 Compare November 20, 2019 15:46

pedropombeiro force-pushed the monorepo branch 2 times, most recently from ba9d593 to b1e63ca Compare November 20, 2019 15:51

pedropombeiro force-pushed the monorepo branch from b1e63ca to 74cabdc Compare November 20, 2019 15:53

pedropombeiro force-pushed the monorepo branch 4 times, most recently from 2fa6e74 to 8533995 Compare November 21, 2019 10:24

pedropombeiro force-pushed the monorepo branch 2 times, most recently from 74f24bf to cd97073 Compare November 21, 2019 13:07

jakubgs requested changes Nov 21, 2019

View reviewed changes

Move to monorepo and submodules

2bf8ff7

pedropombeiro force-pushed the monorepo branch from cd97073 to 2bf8ff7 Compare November 21, 2019 14:39

pedropombeiro force-pushed the monorepo branch from 68452b7 to 0a22eb0 Compare November 21, 2019 15:27

jakubgs approved these changes Nov 21, 2019

View reviewed changes

Rename status-protocol-go to status-go/protocol

fd0333a

pedropombeiro force-pushed the monorepo branch from 0a22eb0 to fd0333a Compare November 21, 2019 15:44

pedropombeiro merged commit ed5a5c1 into develop Nov 21, 2019

delete-merged-branch bot deleted the monorepo branch November 21, 2019 16:19

jakubgs pushed a commit that referenced this pull request Nov 21, 2019

Move to monorepo structure (#1684)

c5b0d9d

Move to a monorepo structure with submodules - Rename status-protocol-go to status-go/protocol Signed-off-by: Jakub Sokołowski <jakub@status.im>

jakubgs pushed a commit that referenced this pull request Nov 21, 2019

Move to monorepo structure (#1684)

47472d2

Move to a monorepo structure with submodules - Rename status-protocol-go to status-go/protocol Signed-off-by: Jakub Sokołowski <jakub@status.im>

0xc1c4da unassigned pedropombeiro Jan 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move to monorepo structure#1684

Move to monorepo structure#1684
pedropombeiro merged 2 commits intodevelopfrom
monorepo

pedropombeiro commented Nov 20, 2019 •

edited by 0xc1c4da

Loading

ghost commented Nov 20, 2019 •

edited by pedropombeiro

Loading

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

status-im-auto commented Nov 20, 2019 •

edited

Loading

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

pedropombeiro commented Nov 21, 2019 •

edited

Loading

jakubgs left a comment

ghost commented Nov 21, 2019

ghost commented Nov 21, 2019

pedropombeiro commented Nov 21, 2019

ghost commented Nov 21, 2019

ghost commented Nov 21, 2019

ghost commented Nov 21, 2019

ghost commented Nov 21, 2019

jakubgs left a comment

ghost commented Nov 21, 2019

pedropombeiro commented Nov 21, 2019

ghost commented Jan 15, 2020

Labels

3 participants

Conversation

pedropombeiro commented Nov 20, 2019 • edited by 0xc1c4da Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ghost commented Nov 20, 2019 • edited by pedropombeiro Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Checklist

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

status-im-auto commented Nov 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jenkins Builds

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

ghost commented Nov 20, 2019

pedropombeiro commented Nov 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

jakubgs left a comment

Choose a reason for hiding this comment

ghost commented Nov 21, 2019

ghost commented Nov 21, 2019

pedropombeiro commented Nov 21, 2019

ghost commented Nov 21, 2019

ghost commented Nov 21, 2019

ghost commented Nov 21, 2019

ghost commented Nov 21, 2019

jakubgs left a comment

Choose a reason for hiding this comment

ghost commented Nov 21, 2019

pedropombeiro commented Nov 21, 2019

ghost commented Jan 15, 2020

Labels

3 participants

pedropombeiro commented Nov 20, 2019 •

edited by 0xc1c4da

Loading

ghost commented Nov 20, 2019 •

edited by pedropombeiro

Loading

status-im-auto commented Nov 20, 2019 •

edited

Loading

pedropombeiro commented Nov 21, 2019 •

edited

Loading