Skip to content

#surveyme in last Note comment should show the Note (even if there are no preceding comments) #6052

@mnalis

Description

@mnalis

Back in #2641 (via b3ad39b), it was made that #surveyme tag in the last comment would always (unless manually hidden by the user) result in showing the OSM Note, even if that comment was created by the same user which is using the app.

In SC 60.0 it works mostly, i.e. if that comment is any but the first one.

I don't think that is intentional (I see no logic for that, nor do the comments seem to indicate the reason for such strange behaviour).
If the user's last comment contains a marker indicating the survey is required and we want to display the note in that case (as we do), then it should not matter how many comments preceded that last one (0 or more).

How to Reproduce

  1. add a comment to existing note with just text test; and note gets hidden - OK
  2. add a comment to existing note with text #surveyme test; and note remains displayed - OK
  3. create a new note with text #surveyme test -- note gets hidden - BAD

Expected Behavior

  • in step (3), note should remain displayed just as in does in (2), as the last message indicates the survey is required.

Versions affected
SC 60.0, Android 14

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions