Mixed ordered and unordered list hierarchies should indent consistently#216
Open
srichy wants to merge 2 commits intoswiftlang:mainfrom
Open
Mixed ordered and unordered list hierarchies should indent consistently#216srichy wants to merge 2 commits intoswiftlang:mainfrom
srichy wants to merge 2 commits intoswiftlang:mainfrom
Conversation
Input like this (but starting in the first column; using CODE blocks here): - This is a top-level bulleted list - This is second-level bulleted list - Second of the second 1. This is ordered and second-order nested 1. Second entry of same should render like: * This is a top-level bulleted list * This is second-level bulleted list * Second of the second 1. This is ordered and second-order nested 2. Second entry of same (given formatting options "unorderedListMarker: .star", "orderedListNumerals:.incrementing(start: 1)", and "emphasisMarker: .underline"). However, before this change, they rendered like: * This is a top-level bulleted list * This is second-level bulleted list * Second of the second 1. This is ordered and second-order nested 2. Second entry of same in which the prefix is not generated for the ordered list. The dump of the tree is correct, however: Document └─ UnorderedList └─ ListItem ├─ Paragraph │ └─ Text "This is a top-level bulleted list" └─ UnorderedList ├─ ListItem │ └─ Paragraph │ └─ Text "This is second-level bulleted list" └─ ListItem ├─ Paragraph │ └─ Text "Second of the second" └─ OrderedList ├─ ListItem │ └─ Paragraph │ └─ Text "This is ordered and second-order nested" └─ ListItem └─ Paragraph └─ Text "Second entry of same" The AST shows that the OrderedList is a child of the ListItem and not of the UnorderedList.
| Please merge this! |
| I'm also being impacted by this, would love to see it be merged soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mixed nested ordered and unordered lists causes indentation prefixes to get dropped in some cases.
Details
Input like this (but starting in the first column; using CODE blocks here):
should render like:
given formatting options
unorderedListMarker: .star,orderedListNumerals:.incrementing(start: 1), andemphasisMarker: .underline.However, before this change, they render like:
in which the prefix is not generated for the ordered list. The dump of the tree is correct, however:
The above AST shows that the OrderedList is a child of the ListItem and not of the UnorderedList, so it should be indented accordingly when rendered.
Dependencies
None
Testing
I sanity tested with the above examples and ran on some other markdown to verify that the output seems sane.