resolves #93 - allows backticks in code voice#259
Open
heckj wants to merge 2 commits intoswiftlang:mainfrom
Open
resolves #93 - allows backticks in code voice#259heckj wants to merge 2 commits intoswiftlang:mainfrom
heckj wants to merge 2 commits intoswiftlang:mainfrom
Conversation
Member Author
| @swift-ci please test |
…t of the interior content
Member Author
| @swift-ci please test |
QuietMisdreavus approved these changes Mar 13, 2026
Contributor
QuietMisdreavus left a comment
QuietMisdreavus left a comment There was a problem hiding this comment.
This looks great, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #93 - which allows backticks to appear in "code voice", used in content within https://github.com/swiftlang/swift-book (see swiftlang/swift-book#71 for some detail in that repo)
This fix leans a concept that symbols when done with backticks, will always use exactly 2 backticks - and adds a smidge of a double check to make sure that the symbol content itself doesn't contain a backtick, which I think is a safe bet.