Make CommandTester::execute input argument use a default value #40
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The reason for this PR is that I stumbled upon this documentation https://symfony.com/doc/current/console.html#testing-commands where the example shows
However, I saw, that the
executemethod already takes the name of the command passed in the constructor if no argument is passed, which means, for commands without input options you can just pass an empty array, therefore you could also make the default value of that argument an empty array.I fixed PSR-2, return types and short array syntax as well, but don't know how Symfony handles that. I did that because composer.json requires php >=7.1 anyway, so all the features should be available, but can change it back if it's not within Symfony standards to do that.