Skip to content

Conversation

@dtfafard
Copy link

Add a way to access the command to create command specific tests related to the given command

Add a way to access the command to create command specific tests related to the given command
@symfony-bot
Copy link

symfony-bot bot commented Mar 20, 2018

Thanks for your pull request! We love contributions.

However, this repository is what we call a "subtree split": a read-only copy of one directory of the main Symfony repository. It is used by Composer to allow developers to depend on specific Symfony components.

If you want to contribute, you should instead open a pull request on the main repository:

https://github.com/symfony/symfony

Thank you for your contribution!

PS: if you haven't already, please add tests, and beware that bug fixes should be submitted on the lowest maintained branch where they apply; only features should be submitted against the master branch.

@symfony-bot symfony-bot bot closed this Mar 20, 2018
@dtfafard
Copy link
Author

I haven't seen any way to unit test the logging system while injecting logger into the command. So I'm thinking of accessing the Command->getLogger() to access the logging system and then access all the logs written in the command.

An other addition might be to add proper documentation in unit testing the Command output when combined with Monolog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant