Skip to content

Conversation

@rudolfratusinski
Copy link
Contributor

In high throughput environments writing message and PHP_EOL separately causes race condition issues, where messages might be written in order

  • message
  • message
  • EOL
  • EOL

instead of

  • message
  • EOL
  • message
  • EOL

An example below is a laravel application queue workers handled by supervisor.

Before:
ezgif-1-77388f9210cf

After:
ezgif-1-0b839d642644

@symfony-bot
Copy link

symfony-bot bot commented Oct 11, 2018

Thanks for your pull request! We love contributions.

However, this repository is what we call a "subtree split": a read-only copy of one directory of the main Symfony repository. It is used by Composer to allow developers to depend on specific Symfony components.

If you want to contribute, you should instead open a pull request on the main repository:

https://github.com/symfony/symfony

Thank you for your contribution!

PS: if you haven't already, please add tests, and beware that bug fixes should be submitted on the lowest maintained branch where they apply; only features should be submitted against the master branch.

@symfony-bot symfony-bot bot closed this Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant