Skip to content

Conversation

@belinde
Copy link

@belinde belinde commented Jun 4, 2019

Referring to issue symfony/symfony#31809

Added check for environment variable set by Konsole and other relateds terminal emulators. Today I'll also open a feature request to Konsole team to support this feature someday.

As it's possible than a more complex logic will be used in future, I've put the checks in a new private method checkHrefSupport().

@symfony-bot
Copy link

symfony-bot bot commented Jun 4, 2019

Thanks for your pull request! We love contributions.

However, this repository is what we call a "subtree split": a read-only copy of one directory of the main Symfony repository. It is used by Composer to allow developers to depend on specific Symfony components.

If you want to contribute, you should instead open a pull request on the main repository:

https://github.com/symfony/symfony

Thank you for your contribution!

PS: if you haven't already, please add tests, and beware that bug fixes should be submitted on the lowest maintained branch where they apply; only features should be submitted against the master branch.

@symfony-bot symfony-bot bot closed this Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant