[JsonStreamer] Merge PropertyMetadata value transformers #61880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| Could this be implemented with a BC layer ? The fact that the component is experimental in 7.3 allows us to do BC breaks in minor versions if needed, but I think this is a case where the BC layer is easy enough to implement. An immediate BC break is more costly for the ecosystem than a deprecation, so we should still prefer doing a deprecation. |
mtarld force-pushed the feat/json-streamer-property-metadata branch 3 times, most recently from 24d593c to 219aa6d Compare mtarld force-pushed the feat/json-streamer-property-metadata branch 3 times, most recently from a34554b to 8e87a1e Compare 
Kocal reviewed Oct 18, 2025
src/Symfony/Component/JsonStreamer/Mapping/PropertyMetadata.php Outdated Show resolved Hide resolved
mtarld force-pushed the feat/json-streamer-property-metadata branch from 8e87a1e to 288dc00 Compare 
nicolas-grekas force-pushed the feat/json-streamer-property-metadata branch from 288dc00 to 0f423f8 Compare 
Member
| Thank you @mtarld. |
mtarld added a commit to mtarld/symfony that referenced this pull request Oct 25, 2025
mtarld added a commit to mtarld/symfony that referenced this pull request Oct 25, 2025
alexandre-daubois added a commit that referenced this pull request Oct 25, 2025
This PR was merged into the 7.4 branch. Discussion ---------- [JsonStreamer] Fix #61880 upmerge | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | F | License | MIT Fix #61880 that triggers deprecation in 7.4 Commits ------- a3bd9be [JsonStreamer] Fix #61880 upmerge
GromNaN added a commit that referenced this pull request Oct 25, 2025
By Mathias Arlaud (2) and Yonel Ceruto (1) Via Alexandre Daubois (2) and others * 7.4: [JsonStreamer] Add deprecation related tests [JsonStreamer] Fix #61880 upmerge Fix argument syntax for callable and lazy initialization of inline service
This was referenced Oct 27, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR merges
PropertyMetadata::$streamToNativeValueTransformersandPropertyMetadata::$nativeToStreamValueTransformerstoPropertyMetadata::$valueTransformers.Indeed, as property metadata is computed in one way at the time (reading or writing), there is no benefit keeping a distinction between native to stream and stream to native.