Skip to content

Add support for more timeouts to Nexus operations #595

Merged
cretz merged 6 commits intotemporalio:mainfrom
Quinn-With-Two-Ns:SDK-4837
Feb 23, 2026
Merged

Add support for more timeouts to Nexus operations #595
cretz merged 6 commits intotemporalio:mainfrom
Quinn-With-Two-Ns:SDK-4837

Conversation

@Quinn-With-Two-Ns
Copy link
Contributor

@Quinn-With-Two-Ns Quinn-With-Two-Ns commented Jan 15, 2026

Add schedule-to-start and start-to-close for Nexus operations

NOTE, before this can be merged the API still needs to be tagged, core changes need to be merged and tests need to be added


Note

Medium Risk
Touches workflow command construction for Nexus operations; incorrect mapping could change timeout behavior or break compatibility with older servers, though coverage is added via new/updated timeout tests.

Overview
Adds ScheduleToStartTimeout and StartToCloseTimeout to NexusOperationOptions and wires them through WorkflowInstance.StartNexusOperationAsync so Nexus operation scheduling can enforce these server-side timeouts (in addition to the existing schedule-to-close).

Extends Nexus worker tests to assert the correct TimeoutType surfaces for schedule-to-close, schedule-to-start, and start-to-close failures, and bumps the local test dev-server download version to pick up the required server support.

Written by Cursor Bugbot for commit 94ed30a. This will update automatically on new commits. Configure here.

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner January 15, 2026 17:25
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Comment on lines +14 to +15
/// Indicates how long the caller is willing to wait for operation completion.
/// Calls are retried internally by the server.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pedantic, but can we move all but the first line of these three docs into a <remarks> section instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, let me know if it looks right

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remarks should not be nested within summary but be a sibling.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks, fixed

@cretz
Copy link
Contributor

cretz commented Feb 20, 2026

LGTM. Merged main and will merge after CI (may be tomorrow)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants