fix: update testing-libary-dom to 9 #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MattyBalaam approved these changes Sep 4, 2023
leonardobumbeers approved these changes Sep 12, 2023
kentcdodds added a commit that referenced this pull request Sep 12, 2023
This should be a major release: #262 BREAKING CHANGE: Upgrade to `@testing-library/dom` v9: https://github.com/testing-library/dom-testing-library/releases/tag/v9.0.0
| 🎉 This PR is included in version 10.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Member
| Keep in mind that a new version of |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What:
Updating testing-library-dom to the latest version
Why:
There were breaking changes in 8->9. Adding this library broke most of our existing jest tests because it requires
testing-library-dom^8.2.1, but the latesttesting-library-reactrequirestesting-library-dom^9.0.0How:
Updates the dependency and fixes a test failure caused by one of the breaking changes in testing-library-dom
Checklist: