Skip to content

Allow setting cron target#845

Open
yakatz wants to merge 2 commits intotheforeman:masterfrom
yakatz:cron_target
Open

Allow setting cron target#845
yakatz wants to merge 2 commits intotheforeman:masterfrom
yakatz:cron_target

Conversation

@yakatz
Copy link

@yakatz yakatz commented Aug 17, 2022

For example, this is useful if you have /var/spool/cron mounted over NFS and use the -c option which would mean Puppet cronjobs would not run on other machines.
yakatz and others added 2 commits August 17, 2022 17:04
@yakatz
Allow tests to pass
91c6b8b
@yakatz
Allow setting cron target
69a7311 
For example, this is useful if you have `/var/spool/cron` mounted over NFS and use the `-c` option which would mean Puppet cronjobs would not run on other machines.
ekohl
ekohl reviewed Aug 22, 2022
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a look at the failing tests first.
spec/classes/puppet_agent_spec.rb
it { is_expected.to contain_class('puppet::agent::service::systemd').with_enabled(false) }
it { is_expected.to contain_service('puppet-run.timer').with_ensure(false) }
it do
is_expected.to contain_cron('puppet')
Copy link
Member

@ekohl ekohl Aug 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also have the with_target()?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment