txnkv: fix the issue that deleteRange cannot use nil as endkey#429
Merged
youjiali1995 merged 1 commit intotikv:masterfrom Feb 24, 2022
Merged
txnkv: fix the issue that deleteRange cannot use nil as endkey#429youjiali1995 merged 1 commit intotikv:masterfrom
youjiali1995 merged 1 commit intotikv:masterfrom
Conversation
Signed-off-by: disksing <i@disksing.com>
Comment on lines +1541 to +1544
| var end []byte | ||
| if len(endKey) > 0 { | ||
| end = codec.EncodeBytes(nil, endKey) | ||
| } |
Contributor
There was a problem hiding this comment.
Why not do it for start key too?
Collaborator Author
There was a problem hiding this comment.
It is innecessary. There will be no key located before "" or encode("") so encode or not encode both are fine.
youjiali1995 approved these changes Feb 24, 2022
| LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #428
Note: it only fix the issue on client side. We need to update tikv to resolve it completely.
Signed-off-by: disksing i@disksing.com