don't call onMemChange before all work is done in memdb#636
Merged
disksing merged 1 commit intotikv:masterfrom Dec 8, 2022
Merged
don't call onMemChange before all work is done in memdb#636disksing merged 1 commit intotikv:masterfrom
disksing merged 1 commit intotikv:masterfrom
Conversation
Signed-off-by: ekexium <eke@fastmail.com>
Contributor Author
Collaborator
| It is reasonable. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref pingcap/tidb#39611
This is a workaround.
The real problem is that we broke the assumption that some functions should not panic. This is related to how the memory tracking system works, which should be discussed later.