Skip to content

fix data race in the LockKeys#655

Merged
disksing merged 3 commits intotikv:masterfrom
hawkingrei:fix_data_kvtxn
Jan 6, 2023
Merged

fix data race in the LockKeys#655
disksing merged 3 commits intotikv:masterfrom
hawkingrei:fix_data_kvtxn

Conversation

@hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 5, 2023

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

ref pingcap/tidb#40350

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei marked this pull request as draft January 5, 2023 12:37
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei marked this pull request as ready for review January 6, 2023 01:44
Copy link
Collaborator

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disksing disksing merged commit 5a4b9ac into tikv:master Jan 6, 2023
@hawkingrei hawkingrei deleted the fix_data_kvtxn branch January 6, 2023 05:31
sticnarf pushed a commit to sticnarf/client-go that referenced this pull request Jan 31, 2023
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
disksing pushed a commit that referenced this pull request Jan 31, 2023
* RuntimeStat: Clone `SnapshotRuntimeStats` Completely (#641) * add more info for cloning SnapshotRuntimeStats Signed-off-by: TonsnakeLin <lpbgytong@163.com> * add more info for cloning SnapshotRuntimeStats Signed-off-by: TonsnakeLin <lpbgytong@163.com> * shallow copy SnapshotRuntimeStats Signed-off-by: TonsnakeLin <lpbgytong@163.com> Signed-off-by: TonsnakeLin <lpbgytong@163.com> Co-authored-by: Yilin Chen <sticnarf@gmail.com> * fix data race in the LockKeys (#655) Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com> * Add a background region cache GC goroutine (#664) Signed-off-by: Yilin Chen <sticnarf@gmail.com> * Rewind after cacheGC reaches the end (#678) Signed-off-by: Yilin Chen <sticnarf@gmail.com> --------- Signed-off-by: TonsnakeLin <lpbgytong@163.com> Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com> Signed-off-by: Yilin Chen <sticnarf@gmail.com> Co-authored-by: TonsnakeLin <87681388+TonsnakeLin@users.noreply.github.com> Co-authored-by: Weizhen Wang <wangweizhen@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants