Actually stop BLE scan in StopScan() on nrf528xx#398
Merged
deadprogram merged 1 commit intotinygo-org:devfrom Dec 6, 2025
Merged
Actually stop BLE scan in StopScan() on nrf528xx#398deadprogram merged 1 commit intotinygo-org:devfrom
deadprogram merged 1 commit intotinygo-org:devfrom
Conversation
Member
Nor am I, but glad to have the correct implementation. Tested on one of my nrf52840 boards and does appear to work as expected and does not cause any unexpected side effects. Thanks for the PR @zopieux now merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on a nrf52840 board.
Without this patch, calling
returns an error on the second
Scan()because the previous scan wasn't actually stopped, since the native call is missing.With this patch, the above succeeds and the scan starts returning results, as usual.
I'm really not sure why there was a TODO rather than this simple function call. The TODO doesn't provide a rationale.