Skip to content

Localization issue :: LC_ALL overwrites LANG #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2020
Merged

Localization issue :: LC_ALL overwrites LANG #50

merged 1 commit into from
Apr 25, 2020

Conversation

@ms-jpq
Copy link
Contributor

@ms-jpq ms-jpq commented Apr 25, 2020

From the old PR here:
#47

we still have issues with localization, mainly that LC_ALL is a commonly exported env variable, and it overwrites LANG.

turns out if you have both variables set (very common), this PR #46 still does not fix the issue

I have attached a photo below that shows the difference

图片
@casperdcl casperdcl self-assigned this Apr 25, 2020
@casperdcl casperdcl added the bug label Apr 25, 2020
@casperdcl
Copy link
Collaborator

casperdcl commented Apr 25, 2020

turns out if you have both variables set (very common), this PR #46 still does not fix the issue

Not sure I understand. You seem to be saying "if you have both variables set it's broken" but then this PR #50 sets both variables.
@ms-jpq
Copy link
Contributor Author

ms-jpq commented Apr 25, 2020

oh, I meant like,
LC_ALL has higher precedence than LANG, so if you have both set: LANG=C gets overwritten by LC_ALL=<something>, and thats why PR #46 by itself is insufficient.

We need to set LC_ALL inside the script to ensure parsing success
@casperdcl casperdcl merged commit f540f07 into tmux-plugins:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug

2 participants

@ms-jpq @casperdcl