Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,7 @@
- Removed rxPermissions and XLog dependencies
- Updated to Python 3.8
* Added support for Kotlin 2.2.0
* Upgraded to Gradle 7.6
* **Breaking change for contributors**: Java 11+ is now required to build the plugin (plugin runtime still targets Java 8)
* Upgraded Rocker plugin from 1.3.0 to 2.2.1
* Upgraded gradle-maven-publish-plugin from 0.18.0 to 0.27.0
7 changes: 7 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@ Contributing to okbuck
The Uber team welcomes contributions of all kinds, from simple bug reports through documentation, test cases,
bugfixes, and features.

Requirements
------------

For building:
- **Java 11+** is required for building the plugin (the plugin itself still targets Java 8 runtime)
- Gradle 7.6 (via wrapper)

Workflow
--------

Expand Down
9 changes: 9 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,15 @@ See the [Usage](https://github.com/uber/okbuck/blob/master/Usage.md) page for co

To speed up your builds even more, you can use an implementation of [Buck's HTTP Cache API](https://github.com/uber/buck-http-cache) to take advantage of building once and using the same build artifacts on all machines.

## Development

To build OkBuck from source:
- **Java 11+** is required (the plugin itself still targets Java 8 runtime)
- Run `./gradlew build` to build the plugin
- Run `./gradlew publishToMavenLocal` to publish to your local Maven repository for testing

See [CONTRIBUTING.md](CONTRIBUTING.md) for detailed contribution guidelines.

## Contributors

We'd love for you to contribute to our open source projects. Before we can accept your contributions, we kindly ask you to sign our [Uber Contributor License Agreement](https://docs.google.com/a/uber.com/forms/d/1pAwS_-dA1KhPlfxzYLBqK6rsSWwRwH95OCCZrcsY5rk/viewform).
Expand Down
4 changes: 2 additions & 2 deletions dependencies.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def versions = [
dagger : "2.33",
kotlin : "1.5.31",
leakCanary : "2.6",
rocker : "1.3.0",
rocker : "2.2.1",
androidx : "1.1.0",
androidxMultidex : "2.0.1",
constraintLayout : "1.1.0",
Expand All @@ -38,7 +38,7 @@ def build = [
androidPlugin : "com.android.tools.build:gradle:${versions.androidPlugin}",
androidPluginApi : "com.android.tools.build:gradle-api:${versions.androidPlugin}",
bcprov : "org.bouncycastle:bcprov-jdk15on:1.60",
gradleMavenPublish: "com.vanniktech:gradle-maven-publish-plugin:0.18.0",
gradleMavenPublish: "com.vanniktech:gradle-maven-publish-plugin:0.27.0",
butterKnifePlugin: "com.jakewharton:butterknife-gradle-plugin:${versions.butterKnife}",
commonsCompress : "org.apache.commons:commons-compress:1.18",
commonsIo : "commons-io:commons-io:2.8.0",
Expand Down
2 changes: 1 addition & 1 deletion dummy-transform/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ plugins {
apply from: "../dependencies.gradle"

dependencies {
compile deps.build.androidPluginApi
implementation deps.build.androidPluginApi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these all need to be impl, or can some be api? (impl is like exported dep)

}
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
android.useAndroidX=true
android.enableJetifier=true
org.gradle.jvmargs=-Xmx4g -XX:MaxPermSize=4096m -XX:+HeapDumpOnOutOfMemoryError -Dfile.encoding=UTF-8
org.gradle.jvmargs=-Xmx4g -XX:+HeapDumpOnOutOfMemoryError -Dfile.encoding=UTF-8 -Dhttps.protocols=TLSv1.2,TLSv1.3
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.8.3-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
4 changes: 2 additions & 2 deletions libraries/groovylibrary/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ plugins {
}

dependencies {
compile deps.external.groovyAll
testCompile deps.test.junit
implementation deps.external.groovyAll
testImplementation deps.test.junit
}
6 changes: 3 additions & 3 deletions libraries/scalalibrary/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ plugins {
}

dependencies {
compile deps.external.scalaLibrary
implementation deps.external.scalaLibrary

testCompile deps.test.scalaTest
testCompile deps.test.scalaTestJunit
testImplementation deps.test.scalaTest
testImplementation deps.test.scalaTestJunit
}

mainClassName = "com.uber.okbuck.scala.example.Hello"
8 changes: 4 additions & 4 deletions transform-cli/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@ mainClassName = "com.uber.okbuck.transform.CliTransform"

dependencies {
compileOnly gradleApi()
compile(deps.build.androidPluginApi) {
implementation(deps.build.androidPluginApi) {
transitive = false
}

testCompile deps.test.junit
testCompile deps.test.mockito
testCompile deps.test.assertj
testImplementation deps.test.junit
testImplementation deps.test.mockito
testImplementation deps.test.assertj
}

shadowJar {
Expand Down
Loading