Pin inter crate dependencies to specific version#1813
Merged
Conversation
deuszx approved these changes Jun 16, 2023
deuszx left a comment
There was a problem hiding this comment.
If they are always released together - you can consider switching to cargo workspace dependencies features and specify it (version, authors, etc.) in root Cargo.toml.
Collaborator Author
Codecov Report
@@ Coverage Diff @@ ## master #1813 +/- ## ========================================== + Coverage 52.14% 52.16% +0.01% ========================================== Files 206 206 Lines 6656 6656 ========================================== + Hits 3471 3472 +1 + Misses 3185 3184 -1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raised by @deuszx.
Currently dependencies between the
inkcrates are specified with a range i.e.4.2.0which means>= 4.2.0, <5.0.This means that when we released
4.2.1recently, and contracts with aninkdependency of4.2.0could pull in the new versions sub crates.This PR pins the versions of the inter-crate dependencies of all the
inkcrates, since they are always released together.