Skip to content

Restrict which cfg attributes can be used#2313

Merged
cmichi merged 7 commits intomasterfrom
cmichi-disallow-cfg-attributes
Dec 3, 2024
Merged

Restrict which cfg attributes can be used#2313
cmichi merged 7 commits intomasterfrom
cmichi-disallow-cfg-attributes

Conversation

@cmichi
Copy link
Collaborator

@cmichi cmichi commented Nov 20, 2024

No description provided.

@cmichi cmichi requested a review from ascjones as a code owner November 20, 2024 11:56
@cmichi cmichi force-pushed the cmichi-disallow-cfg-attributes branch from 4d3cdd2 to 1ba9c1e Compare November 20, 2024 12:21
@codecov
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.82%. Comparing base (e721d84) to head (9e71651).
Report is 2 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #2313 +/- ## ========================================== + Coverage 60.55% 60.82% +0.27%  ========================================== Files 141 141 Lines 5785 5823 +38 Branches 2394 2414 +20 ========================================== + Hits 3503 3542 +39  + Misses 2282 2281 -1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the integration-tests/* contracts from this branch with cargo-contract and comparing them to ink! master:

Contract Upstream Size (kB) PR Size (kB) Diff (kB) Diff (%) Change
call-builder-return-value 8.924 8.924 0 0
e2e-runtime-only-backend 1.925 1.925 0 0
lang-err/call-builder-delegate 2.612 2.612 0 0
lang-err/call-builder 5.66 5.66 0 0
lang-err/constructors-return-value 2.011 2.011 0 0
lang-err/contract-ref 5.087 5.087 0 0
lang-err/integration-flipper 1.91 1.91 0 0
mother 12.681 12.681 0 0
sr25519-verification 1.082 1.082 0 0
storage-types 11.369 11.369 0 0
call-runtime 1.881 1.881 0 0
combined-extension 2.046 2.046 0 0
conditional-compilation 1.46 1.46 0 0
contract-storage 7.459 7.459 0 0
contract-terminate 1.314 1.314 0 0
contract-transfer 1.52 1.52 0 0
contract-xcm 18.805 18.805 0 0
cross-contract-calls 7.471 7.471 0 0
cross-contract-calls/other-contract 1.591 1.591 0 0
custom-allocator 7.993 7.993 0 0
custom-environment 2.062 2.062 0 0
dns 7.142 7.142 0 0
e2e-call-runtime 1.182 1.182 0 0
erc1155 14.566 14.566 0 0
erc20 6.993 6.993 0 0
erc721 9.754 9.754 0 0
events 4.955 4.955 0 0
flipper 1.701 1.701 0 0
incrementer 1.538 1.538 0 0
lazyvec 5.103 5.103 0 0
mapping 8.281 8.281 0 0
multi-contract-caller 6.42 6.42 0 0
multi-contract-caller/accumulator 1.363 1.363 0 0
multi-contract-caller/adder 1.733 1.733 0 0
multi-contract-caller/subber 1.751 1.751 0 0
multisig 21.135 21.135 0 0
payment-channel 5.72 5.72 0 0
psp22-extension 7.372 7.372 0 0
rand-extension 2.957 2.957 0 0
runtime-call-contract 1.592 1.592 0 0
static-buffer 2.602 2.602 0 0
trait-dyn-cross-contract-calls 2.808 2.808 0 0
trait-dyn-cross-contract-calls/contracts/incrementer 1.571 1.571 0 0
trait-erc20 7.286 7.286 0 0
trait-flipper 1.46 1.46 0 0
trait-incrementer 1.63 1.63 0 0
upgradeable-contracts/delegator 3.869 3.869 0 0
upgradeable-contracts/delegator/delegatee 1.652 1.652 0 0
upgradeable-contracts/delegator/delegatee2 1.652 1.652 0 0
upgradeable-contracts/set-code-hash-migration 1.74 1.74 0 0
upgradeable-contracts/set-code-hash-migration/migration 1.302 1.302 0 0
upgradeable-contracts/set-code-hash-migration/updated-incrementer 1.93 1.93 0 0
upgradeable-contracts/set-code-hash 1.74 1.74 0 0
upgradeable-contracts/set-code-hash/updated-incrementer 1.717 1.717 0 0
wildcard-selector 3.234 3.234 0 0

Link to the run | Last update: Fri Nov 29 17:40:14 CET 2024

@cmichi cmichi merged commit 93d1c3e into master Dec 3, 2024
@cmichi cmichi deleted the cmichi-disallow-cfg-attributes branch December 3, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants