Merged
Conversation
6ff320f to 7c8b78a Compare Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #2336 +/- ## ========================================== + Coverage 60.79% 60.83% +0.04% ========================================== Files 141 141 Lines 5823 5829 +6 Branches 2414 2419 +5 ========================================== + Hits 3540 3546 +6 Misses 2283 2283 ☔ View full report in Codecov by Sentry. |
cmichi added a commit that referenced this pull request Dec 4, 2024
* Have port parsing handle comma-separated list * Update changelog
Merged
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Wed Dec 4 12:55:45 CET 2024 |
cmichi added a commit that referenced this pull request Dec 4, 2024
* Bump version to 5.1.1 * Fix port passing from node process (#2336) * Have port parsing handle comma-separated list * Update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2335.
I'll make sure the CI would have catched this in a follow-up PR. The solution there is to migrate to our own Docker image for the CI, the Parity one hasn't been updated in months.