Convert tests using a test server over to pytest #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Introduce a re-usable server_factory fixture to spin up and teardown a varlink test server. Allowing most of the tests to be ported over to pytest assertions.
The three tests use the same test logic so combine them into one test with pytest parametrize's decorator.
Construct `ServiceRequestHandler` once and re-use it in the fixture.
behrmann reviewed Oct 19, 2025
Comment on lines +31 to +36
| yield _create_server | ||
| | ||
| for srv, srv_thread in servers: | ||
| srv.shutdown() | ||
| srv.server_close() | ||
| srv_thread.join() |
Collaborator
There was a problem hiding this comment.
If something goes wrong, it'll probably crash anyway, but maybe we can be on the safe side here
Suggested change
| yield _create_server | |
| for srv, srv_thread in servers: | |
| srv.shutdown() | |
| srv.server_close() | |
| srv_thread.join() | |
| try: | |
| yield _create_server | |
| finally: | |
| for srv, srv_thread in servers: | |
| srv.shutdown() | |
| srv.server_close() | |
| srv_thread.join() |
Collaborator Author
| Note, the |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.