Update Docs #2
Update Docs #2
Conversation
| We should probably wait until GA release with this so that dependency on the vertx-gen can be removed. |
| @zZHorizonZz thanks! AFAIC publishing an interim version for CR8 is fine. |
| @vietj fine with you? |
| Although, do we even need a publish action for GitHub Pages since it is disabled? I assume it is done somehow through an external system. I have updated the build so that we can test properly against all systems windows, unix and mac |
| looks all fine to me |
| @vietj and what about the .run files? Are they necessary, as I have removed them but I'm starting to think they are needed for something else? |
Please revert these changes, they are needed for deployment of the content to the howto website |
| @tsegismont I assume only these two files are needed for proper deployment? |
| @zZHorizonZz files in the |
| @tsegismont Basically, it all boils down to the fact that I want to test builds against all platforms, because there are changes to how the plugin is used. Now you don't need to manually download protobuf-javascript and protoc-gen-grpc-web plugins because they are specified for all platforms, but at the same time, that means publish and build need/should to be separate. |
tsegismont left a comment
tsegismont left a comment There was a problem hiding this comment.
@zZHorizonZz I'm not sure why it's necessary to split build and publish workflows, would it be possible to keep this simple by including a build matrix in the original workflow file?
.github/workflows/build.yml Outdated
| - name: Build with Maven | ||
| run: mvn -B clean install | ||
| | ||
| - name: Cache build artifacts |
There was a problem hiding this comment.
Whats' the purpose of this? I thought the cache: 'maven' config above was enough
.github/workflows/build.yml Outdated
| restore-keys: | | ||
| ${{ runner.os }}-maven- | ||
| - name: Upload build artifacts |
There was a problem hiding this comment.
Is this this for inspection in case of failure?
There was a problem hiding this comment.
I don't personally like running builds twice (because I'm used to builds taking a couple of minutes and because at work we have only one build agent, so you can imagine how that is going). But if you want to merge build and publish back into one file, I think I can do that and remove this.
Co-authored-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont left a comment
tsegismont left a comment There was a problem hiding this comment.
Thank you @zZHorizonZz , looks good to me
| @vietj any comment? Otherwise, we'll go ahead and merge |
3 participants
This PR updates docs and also updates the use of grpc generator.