Skip to content

Remove audio optional dependency for mistral-common#28722

Merged
vllm-bot merged 4 commits intovllm-project:mainfrom
juliendenize:remove_dependency
Nov 14, 2025
Merged

Remove audio optional dependency for mistral-common#28722
vllm-bot merged 4 commits intovllm-project:mainfrom
juliendenize:remove_dependency

Conversation

@juliendenize
Copy link
Copy Markdown
Contributor

@juliendenize juliendenize commented Nov 14, 2025

Purpose

Remove audio optional dependency from mistral-common to fix #8030.

I left it to tests to ensure Voxtral can be tested.

LMK @DarkLight1337 if it works out for you.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.
Signed-off-by: Julien Denize <julien.denize@mistral.ai>
@mergify mergify bot added the ci/build label Nov 14, 2025
Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good, thanks

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 14, 2025 10:32
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 14, 2025
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

msgspec
gguf >= 0.13.0
mistral_common[image,audio] >= 1.8.5
mistral_common[image] >= 1.8.5
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Dropping audio extra removes mandatory test dependency

Removing mistral_common[audio] from the default requirements means packages like librosa and soundfile are no longer installed when setting up the repo via requirements/common.txt. Several audio tests import librosa unconditionally (e.g. tests/multimodal/test_audio.py, tests/models/multimodal/generation/test_phi4_multimodal.py, tests/entrypoints/openai/test_transcription_validation.py), so the test suite now raises ModuleNotFoundError before those modules can mark themselves skipped. Unless the audio tests are explicitly split into an optional suite, the dependency should stay in the base requirements or the tests must guard their imports, otherwise CI and developers running the default setup will be unable to execute the audio-related tests or demos.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test dependencies kept audio optional dependency.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request makes audio dependencies optional by removing [audio] from the mistral_common requirement. While this is a good initiative to keep the base installation lean, the current implementation is incomplete and will break audio functionality for users. I've left a critical comment on requirements/common.txt detailing the necessary accompanying changes, which include setting up an [audio] extra for installation and updating the documentation to guide users. Without these, the change would be a silent breaking change.

Signed-off-by: Julien Denize <julien.denize@mistral.ai>
auto-merge was automatically disabled November 14, 2025 11:03

Head branch was pushed to by a user without write access

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 14, 2025

@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 14, 2025
@juliendenize
Copy link
Copy Markdown
Contributor Author

@DarkLight1337 sorry added some docs as we removed the dependency to inform users.

Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com> Signed-off-by: Julien Denize <40604584+juliendenize@users.noreply.github.com>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 14, 2025 12:24
@vllm-bot vllm-bot merged commit 0854248 into vllm-project:main Nov 14, 2025
86 of 88 checks passed
geodavic pushed a commit to geodavic/vllm that referenced this pull request Nov 16, 2025
Signed-off-by: Julien Denize <julien.denize@mistral.ai> Signed-off-by: Julien Denize <40604584+juliendenize@users.noreply.github.com> Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk> Signed-off-by: George D. Torres <gdavtor@gmail.com>
devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025
Signed-off-by: Julien Denize <julien.denize@mistral.ai> Signed-off-by: Julien Denize <40604584+juliendenize@users.noreply.github.com> Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
kitaekatt pushed a commit to kitaekatt/vllm that referenced this pull request Dec 1, 2025
Signed-off-by: Julien Denize <julien.denize@mistral.ai> Signed-off-by: Julien Denize <40604584+juliendenize@users.noreply.github.com> Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

3 participants