[css-navigation-1] Factor out current from/to URL definitions. #13160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This extracts the defintions of current from URL and current to URL from the definition of the @navigation rule, which both allows them to be used more formally in the definition of the ::link-to() pseudo-class and also makes the definitions a bit more readable. This also cleans up some whitespace in the spec.
noamr approved these changes Nov 26, 2025
Collaborator
noamr left a comment
noamr left a comment There was a problem hiding this comment.
I think we should have an editorial review for this soon, probably use more algorithm steps. Some of these if statements with a lot of conditions are a bit hard to read.
But lets move quickly and revisit this as we go along.
Member Author
| Yeah, I agree this needs more work -- I had been thinking the next step for this (now that it's better encapsulated in this spec) was to file an HTML issue on how to export the definitions we need so that we're not linking into non-exported terms in HTML. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This extracts the defintions of current from URL and current to URL from the definition of the
@navigationrule, which both allows them to be used more formally in the definition of the ::link-to() pseudo-class and also makes the definitions a bit more readable.This also cleans up some whitespace in the spec.