Replace MLActivation with MLRecurrentNetworkActivation#718
Merged
fdwr merged 5 commits intowebmachinelearning:mainfrom Jul 22, 2024
Merged
Replace MLActivation with MLRecurrentNetworkActivation#718fdwr merged 5 commits intowebmachinelearning:mainfrom
fdwr merged 5 commits intowebmachinelearning:mainfrom
Conversation
4 tasks
Contributor Author
| @huningxin PTAL? |
Contributor Author
| Please merge at your convenience (I don't have write access). Thanks! |
Contributor
Contributor Author
| Conflicts resolved! Merge at your convenience 🙏 |
fdwr reviewed Jul 22, 2024
github-actions bot added a commit that referenced this pull request Jul 22, 2024
SHA: 487a992 Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 28, 2024
Implements the changes from this spec PR: webmachinelearning/webnn#718 Bug: 351866391 Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel Change-Id: I163c85af63468a2ad4166509196ac3734d379df2
aarongable pushed a commit to chromium/chromium that referenced this pull request Jul 28, 2024
Implements the changes from this spec PR: webmachinelearning/webnn#718 Bug: 351866391 Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel Change-Id: I163c85af63468a2ad4166509196ac3734d379df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1334041}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 28, 2024
Implements the changes from this spec PR: webmachinelearning/webnn#718 Bug: 351866391 Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel Change-Id: I163c85af63468a2ad4166509196ac3734d379df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1334041}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 28, 2024
Implements the changes from this spec PR: webmachinelearning/webnn#718 Bug: 351866391 Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel Change-Id: I163c85af63468a2ad4166509196ac3734d379df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1334041}
huningxin added a commit to huningxin/webnn-samples that referenced this pull request Jul 29, 2024
According to spec change: webmachinelearning/webnn#718
Honry pushed a commit to webmachinelearning/webnn-samples that referenced this pull request Jul 29, 2024
According to spec change: webmachinelearning/webnn#718
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jul 31, 2024
…rentNetworkActivation, a=testonly Automatic update from web-platform-tests webnn: Replace MLActivation with MLRecurrentNetworkActivation Implements the changes from this spec PR: webmachinelearning/webnn#718 Bug: 351866391 Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel Change-Id: I163c85af63468a2ad4166509196ac3734d379df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1334041} -- wpt-commits: 47b5098ce13c2927fe2913fb97996783c717ca77 wpt-pr: 47325
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Aug 5, 2024
…rentNetworkActivation, a=testonly Automatic update from web-platform-tests webnn: Replace MLActivation with MLRecurrentNetworkActivation Implements the changes from this spec PR: webmachinelearning/webnn#718 Bug: 351866391 Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel Change-Id: I163c85af63468a2ad4166509196ac3734d379df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1334041} -- wpt-commits: 47b5098ce13c2927fe2913fb97996783c717ca77 wpt-pr: 47325
jwidar pushed a commit to jwidar/LatencyZeroGithub that referenced this pull request Sep 16, 2025
…rentNetworkActivation, a=testonly Automatic update from web-platform-tests webnn: Replace MLActivation with MLRecurrentNetworkActivation Implements the changes from this spec PR: webmachinelearning/webnn#718 Bug: 351866391 Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel Change-Id: I163c85af63468a2ad4166509196ac3734d379df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1334041} -- wpt-commits: 47b5098ce13c2927fe2913fb97996783c717ca77 wpt-pr: 47325
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As proposed in #689 (comment)
An
MLRecurrentNetworkActivationenum is sufficient for describing activation functions passed to recurrent operators likelstmandgruPreview | Diff