Skip to content

Conversation

@malcolm-kee
Copy link
Contributor

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No new test. Old tests are fixed.

Before

before

After

after

Motivation / Use-Case

Breaking Changes

Additional Info

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 19, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: malcolm-kee / name: Malcolm Kee (5acd22d)

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Base: 92.06% // Head: 92.06% // No change to project coverage 👍

Coverage data is based on head (5acd22d) compared to base (5d4b347).
Patch has no changes to coverable lines.

Additional details and impacted files
@@ Coverage Diff @@ ## master #4575 +/- ## ======================================= Coverage 92.06% 92.06% ======================================= Files 16 16 Lines 1639 1639 Branches 617 617 ======================================= Hits 1509 1509 Misses 119 119 Partials 11 11 

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@malcolm-kee
Copy link
Contributor Author

Code coverage dropped but I not sure how could that happen as I just fix the example config.

@alexander-akait alexander-akait merged commit ef2f9e9 into webpack:master Sep 19, 2022
@malcolm-kee malcolm-kee deleted the fix/example-not-working branch May 11, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants