Merged
Conversation
huan requested changes Jun 14, 2023
Member
huan left a comment
huan left a comment There was a problem hiding this comment.
PLEASE KEEP THE ORIGINAL NUMBER OR OUR ECOSYSTEM WILL BE BROKEN.
proto/wechaty/puppet/message.proto Outdated
| MESSAGE_TYPE_CHAT_HISTORY = 8; | ||
| MESSAGE_TYPE_LOCATION = 9; | ||
| MESSAGE_TYPE_MINI_PROGRAM = 10; | ||
| MESSAGE_TYPE_CHAT_HISTORY = 4; |
Member
There was a problem hiding this comment.
OOPS! NEVER CHANGE THE ENUM NUMBER IN A PROTO FILE!
THIS WILL BREAK ALL PREVIOUS VERSION COMPATIBILITIES!
Member Author
There was a problem hiding this comment.
Done. I was trying to make the message type enum in grpc match with the one in wechaty-puppet. I did not notice the diffrence in order.
hcfw007 force-pushed the feat/system-message-wechaty branch from aaf16b9 to 0bb5853 Compare 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: wechaty/wechaty#2522